Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268632
Change subject: TransltionUnit: Check for sequenceId
......................................................................
TransltionUnit: Check for sequenceId
sequenceId is a nullable column in the table. So the check done
in this commit is technically correct. At the same time, it is
important to find what situation can cause this. To be investigated
as followup.
Bug: T125783
Change-Id: I9da8a1f9e47fb18f82f44a6a3e30f9fd627f6984
---
M includes/TranslationUnit.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/32/268632/1
diff --git a/includes/TranslationUnit.php b/includes/TranslationUnit.php
index b587b5b..485d079 100644
--- a/includes/TranslationUnit.php
+++ b/includes/TranslationUnit.php
@@ -21,7 +21,9 @@
$this->translationId = (int)$params['translationId'];
$this->sectionId = (string)$params['sectionId'];
$this->origin = (string)$params['origin'];
- $this->sequenceId = (int)$params['sequenceId'];
+ if ( isset( $params['sequenceId'] ) ) {
+ $this->sequenceId = (int)$params['sequenceId'];
+ }
$this->content = (string)$params['content'];
if ( isset( $params['timestamp'] ) ) {
$this->timestamp = (int)$params['timestamp'];
--
To view, visit https://gerrit.wikimedia.org/r/268632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9da8a1f9e47fb18f82f44a6a3e30f9fd627f6984
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
