Ori.livneh has submitted this change and it was merged. Change subject: test isValid ......................................................................
test isValid Extract validationCases out of validate test, move eventLog.warn redefinition into validate test Add isValid test that does assertFalse() on validationCases. Still some more to add. Change-Id: Ie284072116964b1d157aececaa527dad9c680aba --- M tests/ext.eventLogging.tests.js 1 file changed, 64 insertions(+), 33 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/42371 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie284072116964b1d157aececaa527dad9c680aba Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
