Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268831
Change subject: Added wgOpenStackManagerSkipArticleEdits.
......................................................................
Added wgOpenStackManagerSkipArticleEdits.
Article edits are incredibly expensive when we are e.g. adding many
members to an article. This global can be set to 'true' during
maintenance scripts to speed things up.
Change-Id: I8500498312074013c8b48f4c7071638bbe9dd8aa
---
M OpenStackManager.php
M nova/OpenStackNovaInstance.php
M nova/OpenStackNovaProject.php
3 files changed, 20 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager
refs/changes/31/268831/1
diff --git a/OpenStackManager.php b/OpenStackManager.php
index d70a86d..132a59f 100644
--- a/OpenStackManager.php
+++ b/OpenStackManager.php
@@ -170,6 +170,9 @@
// A list of regions which are visible yet disabled (e.g. instance creation
forbidden)
$wgOpenStackManagerReadOnlyRegions = array();
+// Suppress article page updates, useful during big expensive maintenance tasks
+$wgOpenStackManagerSkipArticleEdits = false;
+
$dir = __DIR__ . '/';
$wgMessagesDirs['OpenStackManager'] = __DIR__ . '/i18n';
diff --git a/nova/OpenStackNovaInstance.php b/nova/OpenStackNovaInstance.php
index 1c04fc3..08834e5 100644
--- a/nova/OpenStackNovaInstance.php
+++ b/nova/OpenStackNovaInstance.php
@@ -262,6 +262,12 @@
* @param $userNova
*/
function editArticle( $userNova ) {
+ global $wgOpenStackManagerSkipArticleEdits;
+
+ if ( $wgOpenStackManagerSkipArticleEdits ) {
+ return;
+ }
+
if ( ! OpenStackNovaArticle::canCreatePages() ) {
return;
}
@@ -324,6 +330,12 @@
}
function deleteArticle() {
+ global $wgOpenStackManagerSkipArticleEdits;
+
+ if ( $wgOpenStackManagerSkipArticleEdits ) {
+ return;
+ }
+
$host = $this->getHost();
if ( $host ) {
OpenStackNovaArticle::deleteArticle(
$host->getFullyQualifiedHostName() );
diff --git a/nova/OpenStackNovaProject.php b/nova/OpenStackNovaProject.php
index ea8820f..5c8b466 100644
--- a/nova/OpenStackNovaProject.php
+++ b/nova/OpenStackNovaProject.php
@@ -761,7 +761,11 @@
function editArticle() {
global $wgOpenStackManagerCreateProjectSALPages,
$wgOpenStackManagerProjectNamespace,
- $wgOpenStackManagerBastionProjectName;
+ $wgOpenStackManagerBastionProjectName,
$wgOpenStackManagerSkipArticleEdits;
+
+ if ( $wgOpenStackManagerSkipArticleEdits ) {
+ return;
+ }
if ( ! OpenStackNovaArticle::canCreatePages() ) {
return;
--
To view, visit https://gerrit.wikimedia.org/r/268831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8500498312074013c8b48f4c7071638bbe9dd8aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
