Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268883
Change subject: OutputPage.php: Remove misleading comment
......................................................................
OutputPage.php: Remove misleading comment
The whole comment was added in fc359e16f1 together with a strtolower().
In dcd44cdf7d the strtolower() and a part of the comment was removed.
The rest of the comment makes no sense without a strtolower().
Change-Id: Ifa0d88a618e31f4a558bc93a098aabad35761569
---
M includes/OutputPage.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/83/268883/1
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 3adef5b..244b713 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3613,8 +3613,6 @@
*/
public function addStyle( $style, $media = '', $condition = '', $dir =
'' ) {
$options = array();
- // Even though we expect the media type to be lowercase, but
here we
- // force it to lowercase to be safe.
if ( $media ) {
$options['media'] = $media;
}
--
To view, visit https://gerrit.wikimedia.org/r/268883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa0d88a618e31f4a558bc93a098aabad35761569
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
