[MediaWiki-commits] [Gerrit] KeyDownHandlers: Make Tab behave the same in table cells as ... - change (VisualEditor/VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/268898

Change subject: KeyDownHandlers: Make Tab behave the same in table cells as in 
table selections
......................................................................

KeyDownHandlers: Make Tab behave the same in table cells as in table selections

Bug: T125378
Change-Id: Ib042c7c255458a39ec54651bb304bafcd7366eb0
---
M src/ce/keydownhandlers/ve.ce.LinearTabKeyDownHandler.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/98/268898/1

diff --git a/src/ce/keydownhandlers/ve.ce.LinearTabKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearTabKeyDownHandler.js
index 0ebc135..3347253 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearTabKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearTabKeyDownHandler.js
@@ -49,7 +49,7 @@
                        surface,
                        0, // rows
                        e.shiftKey ? -1 : 1, // columns
-                       true, // respect rtl/ltr
+                       false, // logical direction, not visual
                        false // don't expand the current selection
                );
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/268898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib042c7c255458a39ec54651bb304bafcd7366eb0
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits