Yaron Koren has submitted this change and it was merged.

Change subject: Use strict array search for linker options.
......................................................................


Use strict array search for linker options.

This is in anticipation of gerrit change
I16b9d6c3044ae60d5a7fd340569c019ffc4b2a55 (and a good practice
anyway).

Change-Id: Idd8de9b7c187f3e50c976ab8db2b5dffe1e54ede
---
M includes/SF_FormLinker.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SF_FormLinker.php b/includes/SF_FormLinker.php
index 6abe511..38d6e5c 100644
--- a/includes/SF_FormLinker.php
+++ b/includes/SF_FormLinker.php
@@ -323,7 +323,7 @@
         */
        static function setBrokenLink( $linker, $target, $options, $text, 
&$attribs, &$ret ) {
                // If it's not a broken (red) link, exit.
-               if ( !in_array( 'broken', $options ) ) {
+               if ( !in_array( 'broken', $options, true ) ) {
                        return true;
                }
                // If the link is to a special page, exit.

-- 
To view, visit https://gerrit.wikimedia.org/r/268908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd8de9b7c187f3e50c976ab8db2b5dffe1e54ede
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to