Tim Landscheidt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268931
Change subject: Let take fail if recursion failed
......................................................................
Let take fail if recursion failed
Currently, calling take on a directory succeeds if the directory
itself could be assumed ownership of regardless of its children.
While the logic to sum up the results of the recursion was in the
source code, its result was ignored.
This change implements the common behaviour for a program to only
succeed if there were no errors at all.
Change-Id: I3415bf8ee0643a1f16191426b804684680878a20
---
M src/take.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs
refs/changes/31/268931/1
diff --git a/src/take.cc b/src/take.cc
index 81128c8..96e3e98 100755
--- a/src/take.cc
+++ b/src/take.cc
@@ -157,6 +157,8 @@
ok &= takeover(d->d_name, true);
}
closedir(df);
+
+ return ok;
} else
return error(path);
}
--
To view, visit https://gerrit.wikimedia.org/r/268931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3415bf8ee0643a1f16191426b804684680878a20
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
