jenkins-bot has submitted this change and it was merged.
Change subject: DesktopArticleTarget#editSource: Use actionFactory to create a
window with the surface
......................................................................
DesktopArticleTarget#editSource: Use actionFactory to create a window with the
surface
So the normal logic is used to close other windows etc.
Bug: T125479
Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 54dc82e..d9b7722 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -803,7 +803,8 @@
this.getSurface().getView().getDocument().getDocumentNode().$element.css(
'opacity', 0.5 );
- this.getSurface().getDialogs().openWindow( 'wikitextswitchconfirm', {
target: this } );
+ ve.ui.actionFactory.create( 'window', this.getSurface() )
+ .open( 'wikitextswitchconfirm', { target: this } );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/268857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
