Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268963
Change subject: cloneElements: Use the correct node type when cloning
......................................................................
cloneElements: Use the correct node type when cloning
Bug: T126169
Change-Id: Id8024c171cfb4350152c150b615282cc65de3d41
---
M src/dm/lineardata/ve.dm.ElementLinearData.js
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/63/268963/1
diff --git a/src/dm/lineardata/ve.dm.ElementLinearData.js
b/src/dm/lineardata/ve.dm.ElementLinearData.js
index 91059bc..8ec0bc0 100644
--- a/src/dm/lineardata/ve.dm.ElementLinearData.js
+++ b/src/dm/lineardata/ve.dm.ElementLinearData.js
@@ -1142,10 +1142,13 @@
* @param {boolean} preserveGenerated Preserve internal.generated properties
of elements
*/
ve.dm.ElementLinearData.prototype.cloneElements = function ( preserveGenerated
) {
- var i, len;
+ var i, len, nodeClass;
for ( i = 0, len = this.getLength(); i < len; i++ ) {
if ( this.isOpenElementData( i ) ) {
- this.setData( i, ve.dm.Node.static.cloneElement(
this.getData( i ), preserveGenerated ) );
+ nodeClass = ve.dm.nodeFactory.lookup( this.getType( i )
);
+ if ( nodeClass ) {
+ this.setData( i, nodeClass.static.cloneElement(
this.getData( i ), preserveGenerated ) );
+ }
}
}
};
--
To view, visit https://gerrit.wikimedia.org/r/268963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8024c171cfb4350152c150b615282cc65de3d41
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
