Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269081
Change subject: build: Bump various devDeps to latest and make pass
......................................................................
build: Bump various devDeps to latest and make pass
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
This version of the linter cleans up a number of options. 'es5' is now
assumed to be
true by default, and replaced as 'esversion'; 'latedef' is extended to also
cover
functions' defintions, disabled for us for now; 'futurehostile' is introduced
to aid
future-incompatible names for ES6+ support.
I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this
file is
meant to be loaded by all JS-capable clients to determine if it is (amongst
other
things) capable of ES5, so now we assert ES3 compatibility via jshint.
* grunt-jscs: 2.5.0 -> 2.7.0
Minor version bump that doesn't affect us.
* grunt-jsonlint: 1.0.6 -> 1.0.7
Trivial version bump that doesn't affect us.
Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
---
M .jshintrc
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
M package.json
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/81/269081/1
diff --git a/.jshintrc b/.jshintrc
index a65020c..30cc13d 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -3,15 +3,16 @@
"bitwise": true,
"eqeqeq": true,
"freeze": true,
- "latedef": true,
+ "latedef": "nofunc",
+ "futurehostile": true,
"noarg": true,
"nonew": true,
"undef": true,
"unused": true,
+
"strict": false,
// Relaxing
- "es5": false,
// Environment
"browser": true,
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 05f1226..01cc770 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -9,6 +9,8 @@
* @license The MIT License (MIT); see LICENSE.txt
*/
+/* jshint esversion: 3 */
+
/**
* Platform preparation for the MediaWiki view page. This loads (when user
needs it) the
* actual MediaWiki integration and VisualEditor library.
diff --git a/package.json b/package.json
index 3508ebe..40eb475 100644
--- a/package.json
+++ b/package.json
@@ -11,13 +11,13 @@
"devDependencies": {
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
- "grunt-jsonlint": "1.0.6",
+ "grunt-jsonlint": "1.0.7",
"grunt-banana-checker": "0.4.0",
"grunt-contrib-copy": "0.8.2",
"grunt-contrib-csslint": "0.5.0",
- "grunt-contrib-jshint": "0.11.3",
+ "grunt-contrib-jshint": "0.12.0",
"grunt-contrib-watch": "0.6.1",
- "grunt-jscs": "2.5.0",
+ "grunt-jscs": "2.7.0",
"grunt-tyops": "0.1.0"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/269081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
