Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269106
Change subject: Ignore RC_EXTERNAL changes for RecentChange_Save
......................................................................
Ignore RC_EXTERNAL changes for RecentChange_Save
It seems the following extensions already has special
handeling, generally ignoring external edits:
- Gather
- MobileFrontend
- AbuseFilter
- FlaggedRevs
Bug: T125664
Change-Id: If97bb829327b108fddd14641946fed946eb0ea75
---
M CheckUser.hooks.php
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CheckUser
refs/changes/06/269106/1
diff --git a/CheckUser.hooks.php b/CheckUser.hooks.php
index 9314589..0cf278f 100755
--- a/CheckUser.hooks.php
+++ b/CheckUser.hooks.php
@@ -17,6 +17,14 @@
if ( defined( 'RC_CATEGORIZE' ) && $rc->getAttribute( 'rc_type'
) == RC_CATEGORIZE ) {
return true;
}
+ /**
+ * RC_EXTERNAL recent changes are not triggered by actions on
th local wiki.
+ * Thus there is no reason to store checkuser data about them.
+ * @see https://phabricator.wikimedia.org/T125664
+ */
+ if ( defined( 'RC_EXTERNAL' ) && $rc->getAttribute( 'rc_type' )
== RC_EXTERNAL ) {
+ return true;
+ }
$attribs = $rc->getAttributes();
// Get IP
--
To view, visit https://gerrit.wikimedia.org/r/269106
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If97bb829327b108fddd14641946fed946eb0ea75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CheckUser
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
