jenkins-bot has submitted this change and it was merged. Change subject: Use strict array search for linker options. ......................................................................
Use strict array search for linker options. This is in anticipation of gerrit change I16b9d6c3044ae60d5a7fd340569c019ffc4b2a55 (and a good practice anyway). Change-Id: I797ba989b041d22f18e5acb5d21f869e2b5d10b7 --- M HelpCommons.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anomie: Looks good to me, approved jenkins-bot: Verified diff --git a/HelpCommons.php b/HelpCommons.php index a2169e4..8463f15 100644 --- a/HelpCommons.php +++ b/HelpCommons.php @@ -610,7 +610,7 @@ if ( !isset( $pageData['missing'] ) ) { // remove "broken" assumption/override - $brokenKey = array_search( 'broken', $options ); + $brokenKey = array_search( 'broken', $options, true ); if ( $brokenKey !== false ) { unset( $options[$brokenKey] ); } -- To view, visit https://gerrit.wikimedia.org/r/268906 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I797ba989b041d22f18e5acb5d21f869e2b5d10b7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/HelpCommons Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits