jenkins-bot has submitted this change and it was merged.
Change subject: OO.ui.CapsuleMultiSelectWidget: Edit instead of remove on
backspace
......................................................................
OO.ui.CapsuleMultiSelectWidget: Edit instead of remove on backspace
Bug: T121201
Change-Id: I8bd3f7a64ddb1df3cd3b6375ac13a33b72dbca6e
---
M src/widgets/CapsuleMultiSelectWidget.js
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/CapsuleMultiSelectWidget.js
b/src/widgets/CapsuleMultiSelectWidget.js
index 0ea8429..a1f09e0 100644
--- a/src/widgets/CapsuleMultiSelectWidget.js
+++ b/src/widgets/CapsuleMultiSelectWidget.js
@@ -337,6 +337,18 @@
};
/**
+ * Removes the item from the list and copies its label to `this.$input`.
+ *
+ * @param {Object} item
+ */
+OO.ui.CapsuleMultiSelectWidget.prototype.editItem = function ( item ) {
+ this.$input.val( item.label );
+ this.updateInputSize();
+ this.focus();
+ this.removeItems( [ item ] );
+};
+
+/**
* @inheritdoc
*/
OO.ui.CapsuleMultiSelectWidget.prototype.removeItems = function ( items ) {
@@ -504,7 +516,7 @@
// 'keypress' event is not triggered for Backspace
if ( e.keyCode === OO.ui.Keys.BACKSPACE && this.$input.val()
=== '' ) {
if ( this.items.length ) {
- this.removeItems( this.items.slice( -1 ) );
+ this.editItem( this.items[ this.items.length -
1 ] );
}
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/268075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bd3f7a64ddb1df3cd3b6375ac13a33b72dbca6e
Gerrit-PatchSet: 6
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
