jenkins-bot has submitted this change and it was merged.
Change subject: SelectWidget: Really prevent default action during
type-to-select
......................................................................
SelectWidget: Really prevent default action during type-to-select
Contrary to the documentation, this was a plain DOM event handler (and
not jQuery event handler), so returning 'false' didn't do anything.
Bug: T126239
Change-Id: Icf48579e53f8e17178a7b5dbe5e6ab5ee7ef0c0f
---
M src/widgets/SelectWidget.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 8f579ca..550e681 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -340,7 +340,7 @@
* Handle key press events.
*
* @protected
- * @param {jQuery.Event} e Key press event
+ * @param {KeyboardEvent} e Key press event
*/
OO.ui.SelectWidget.prototype.onKeyPress = function ( e ) {
var c, filter, item;
@@ -388,7 +388,8 @@
item.scrollElementIntoView();
}
- return false;
+ e.preventDefault();
+ e.stopPropagation();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/269164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf48579e53f8e17178a7b5dbe5e6ab5ee7ef0c0f
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
