jenkins-bot has submitted this change and it was merged.
Change subject: tests: Correct order of expected/actual in setProp tests
......................................................................
tests: Correct order of expected/actual in setProp tests
Change-Id: I3a32e65cc87cfdcf59385ba14223c3e0bafa52fe
---
M tests/unit/core.test.js
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/unit/core.test.js b/tests/unit/core.test.js
index 22eb296..242efc0 100644
--- a/tests/unit/core.test.js
+++ b/tests/unit/core.test.js
@@ -229,25 +229,25 @@
QUnit.test( 'setProp( ' + type + ' )', function (
assert ) {
oo.setProp( obj, 'foo', 4 );
- assert.strictEqual( 4, obj.foo, 'setting an
existing key with depth 1' );
+ assert.strictEqual( obj.foo, 4, 'setting an
existing key with depth 1' );
oo.setProp( obj, 'test', 'TEST' );
- assert.strictEqual( 'TEST', obj.test, 'setting
a new key with depth 1' );
+ assert.strictEqual( obj.test, 'TEST', 'setting
a new key with depth 1' );
oo.setProp( obj, 'bar', 'quux', 'whee', 'YAY' );
- assert.strictEqual( 'YAY', obj.bar.quux.whee,
'setting an existing key with depth 3' );
+ assert.strictEqual( obj.bar.quux.whee, 'YAY',
'setting an existing key with depth 3' );
oo.setProp( obj, 'bar', 'a', 'b', 'c' );
- assert.strictEqual( 'c', obj.bar.a.b, 'setting
two new keys within an existing key' );
+ assert.strictEqual( obj.bar.a.b, 'c', 'setting
two new keys within an existing key' );
oo.setProp( obj, 'a', 'b', 'c', 'd', 'e', 'f' );
- assert.strictEqual( 'f', obj.a.b.c.d.e,
'setting new keys with depth 5' );
+ assert.strictEqual( obj.a.b.c.d.e, 'f',
'setting new keys with depth 5' );
oo.setProp( obj, 'bar', 'baz', 'whee', 'wheee',
'wheeee' );
- assert.strictEqual( null, obj.bar.baz,
'descending into null fails silently' );
+ assert.strictEqual( obj.bar.baz, null,
'descending into null fails silently' );
oo.setProp( obj, 'foo', 'bar', 5 );
- assert.strictEqual( 4, obj.foo, 'descending
into primitive (number) preserves fails silently' );
+ assert.strictEqual( obj.foo, 4, 'descending
into primitive (number) preserves fails silently' );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/269112
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a32e65cc87cfdcf59385ba14223c3e0bafa52fe
Gerrit-PatchSet: 2
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
