Relwell has uploaded a new change for review.

Change subject: Register an error if the user input for references generates a 
malformed DOM
......................................................................

Register an error if the user input for references generates a malformed DOM

This addresses a defect where an unclosed <references> tag will hide all text 
within it from
the core parser without issuing a warning. A more suitable behavior would be to 
issue a warning that
the user has used this tag incorrectly.

The <references> tag should only contain instances of the <ref> tag for the 
purpose of specifying
reused footnotes. By enforcing that the <references> tag not contain strings 
that do not include <ref> tags, we can at
least be certain that there are no unexpected text nodes. This will prevent the 
user from making
changes that prevent content following references from being displayed.

This defect is related to an issue with the Wikia Visual Editor, reported at 
https://github.com/Wikia/app/pull/313

Change-Id: I4808c83c056c29f71fb2b03cff638a7cf32df26d
---
M Cite.i18n.php
M Cite_body.php
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/80/42880/1
--
To view, visit https://gerrit.wikimedia.org/r/42880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4808c83c056c29f71fb2b03cff638a7cf32df26d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Relwell <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to