jenkins-bot has submitted this change and it was merged.

Change subject: Don't try to tell the server to set preferences to their 
current values
......................................................................


Don't try to tell the server to set preferences to their current values

It's rather pointless.

Change-Id: I8065af1d61108ce843c0afd2eaa0f1f9b85b6998
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 01cc770..2341b3b 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -250,7 +250,7 @@
                $.cookie( 'VEE', editor, { path: '/', expires: 30 } );
                if ( mw.user.isAnon() ) {
                        return $.Deferred().resolve();
-               } else {
+               } else if ( mw.user.options.get( 'visualeditor-editor' ) !== 
editor ) {
                        return new mw.Api().saveOption( 'visualeditor-editor', 
editor ).then( function () {
                                mw.user.options.set( 'visualeditor-editor', 
editor );
                        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/269462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8065af1d61108ce843c0afd2eaa0f1f9b85b6998
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to