Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/269612

Change subject: Add Generic.Arrays.DisallowLongArraySyntax to ruleset, autofix 
this repo
......................................................................

Add Generic.Arrays.DisallowLongArraySyntax to ruleset, autofix this repo

Change-Id: I2a805d7e43b92ccde87d244a17b96b0f1be332c9
---
M MediaWiki/Sniffs/AlternativeSyntax/AlternativeSyntaxSniff.php
M MediaWiki/Sniffs/ControlStructures/AssignmentInControlStructuresSniff.php
M MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
M MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php
M MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php
M MediaWiki/Sniffs/NamingConventions/ValidGlobalNameSniff.php
M MediaWiki/Sniffs/Usage/DirUsageSniff.php
M MediaWiki/Sniffs/Usage/GotoUsageSniff.php
M MediaWiki/Sniffs/VariableAnalysis/UnusedGlobalVariablesSniff.php
M MediaWiki/Sniffs/WhiteSpace/MultipleEmptyLinesSniff.php
M MediaWiki/Sniffs/WhiteSpace/SpaceAfterControlStructureSniff.php
M MediaWiki/Sniffs/WhiteSpace/SpaceBeforeSingleLineCommentSniff.php
M MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
M MediaWiki/Tests/MediaWikiStandardTest.php
M MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax_pass.php
M 
MediaWiki/Tests/files/ControlStructures/assignment_in_control_structures_pass.php
M MediaWiki/Tests/files/NamingConventions/wf_namespace_pass.php
M MediaWiki/Tests/files/WhiteSpace/space_before_parens_pass.php
M MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis_pass.php
M MediaWiki/Tests/files/generic_pass.php
M MediaWiki/ruleset.xml
M TestHelper.php
22 files changed, 68 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/12/269612/1

diff --git a/MediaWiki/Sniffs/AlternativeSyntax/AlternativeSyntaxSniff.php 
b/MediaWiki/Sniffs/AlternativeSyntax/AlternativeSyntaxSniff.php
index 9924e6a..7c3d082 100644
--- a/MediaWiki/Sniffs/AlternativeSyntax/AlternativeSyntaxSniff.php
+++ b/MediaWiki/Sniffs/AlternativeSyntax/AlternativeSyntaxSniff.php
@@ -9,20 +9,20 @@
        public function register() {
                // Per 
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP
                // section on alternative syntax.
-               return array(
+               return [
                        T_ENDDECLARE,
                        T_ENDFOR,
                        T_ENDFOREACH,
                        T_ENDIF,
                        T_ENDSWITCH,
                        T_ENDWHILE,
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
                $tokens = $phpcsFile->getTokens();
                $error = 'Alternative syntax such as "%s" should not be used';
-               $data = array( $tokens[$stackPtr]['content'] );
+               $data = [ $tokens[$stackPtr]['content'] ];
                $phpcsFile->addWarning( $error, $stackPtr, 'AlternativeSyntax', 
$data );
        }
 }
diff --git 
a/MediaWiki/Sniffs/ControlStructures/AssignmentInControlStructuresSniff.php 
b/MediaWiki/Sniffs/ControlStructures/AssignmentInControlStructuresSniff.php
index 21786e8..4ea1f08 100644
--- a/MediaWiki/Sniffs/ControlStructures/AssignmentInControlStructuresSniff.php
+++ b/MediaWiki/Sniffs/ControlStructures/AssignmentInControlStructuresSniff.php
@@ -15,11 +15,11 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array(
+               return [
                        T_IF,
                        T_WHILE,
                        T_ELSEIF,
-               );
+               ];
        }
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
                $tokens = $phpcsFile->getTokens();
diff --git a/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php 
b/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
index fb46827..005da88 100644
--- a/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
+++ b/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
@@ -11,10 +11,10 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array(
+               return [
                        T_ELSE,
                        T_ELSEIF,
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -27,7 +27,7 @@
                                'Single space expected before "%s"',
                                $stackPtr + 1,
                                'SpaceBeforeElse',
-                               array( $tokens[$stackPtr]['content'] )
+                               [ $tokens[$stackPtr]['content'] ]
                        );
                        if ( $fix === true ) {
                                if ( $prevToken['code'] === 
T_CLOSE_CURLY_BRACKET ) {
diff --git 
a/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php 
b/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php
index a27df2b..f00f447 100644
--- a/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php
+++ b/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php
@@ -7,7 +7,7 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array( T_OPEN_TAG );
+               return [ T_OPEN_TAG ];
        }
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
                // do nothing if opening tag is the first character
@@ -16,7 +16,7 @@
                }
                $tokens = $phpcsFile->getTokens();
                $isNotFirstOpenTag = $phpcsFile->findPrevious(
-                       array( T_OPEN_TAG ),
+                       [ T_OPEN_TAG ],
                        ( $stackPtr - 1 ),
                        null,
                        false
diff --git 
a/MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php 
b/MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php
index 1f1f867..f2c7481 100644
--- a/MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php
+++ b/MediaWiki/Sniffs/NamingConventions/PrefixedGlobalFunctionsSniff.php
@@ -9,10 +9,10 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
 
-       public $ignoreList = array();
+       public $ignoreList = [];
 
        public function register() {
-               return array( T_FUNCTION );
+               return [ T_FUNCTION ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -44,7 +44,7 @@
                                $expected = 'wf' . ucfirst( $name );
 
                                $error = 'Global function "%s" is lacking a 
\'wf\' prefix. Should be "%s".';
-                               $data = array( $name, $expected );
+                               $data = [ $name, $expected ];
                                $phpcsFile->addError( $error, $stackPtr, 
'wfPrefix', $data );
                        }
                }
diff --git a/MediaWiki/Sniffs/NamingConventions/ValidGlobalNameSniff.php 
b/MediaWiki/Sniffs/NamingConventions/ValidGlobalNameSniff.php
index c2219bd..3596e04 100644
--- a/MediaWiki/Sniffs/NamingConventions/ValidGlobalNameSniff.php
+++ b/MediaWiki/Sniffs/NamingConventions/ValidGlobalNameSniff.php
@@ -9,7 +9,7 @@
        /**
         * http://php.net/manual/en/reserved.variables.argv.php
         */
-       private static $PHPReserved = array(
+       private static $PHPReserved = [
                '$GLOBALS',
                '$_SERVER',
                '$_GET',
@@ -24,12 +24,12 @@
                '$http_response_header',
                '$argc',
                '$argv'
-       );
+       ];
 
-       public $ignoreList = array();
+       public $ignoreList = [];
 
        public function register() {
-               return array( T_GLOBAL );
+               return [ T_GLOBAL ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -60,7 +60,7 @@
                                                'Global variable "%s" is 
lacking \'wg\' prefix. Should be "%s".',
                                                $stackPtr,
                                                'wgPrefix',
-                                               array( $globalName, $expected )
+                                               [ $globalName, $expected ]
                                        );
                                } else {
                                        // Verify global is probably CamelCase
@@ -70,7 +70,7 @@
                                                        'Global variable "%s" 
should use CamelCase: "%s"',
                                                        $stackPtr,
                                                        'CamelCase',
-                                                       array( $globalName, 
$expected )
+                                                       [ $globalName, 
$expected ]
                                                );
                                        }
                                }
diff --git a/MediaWiki/Sniffs/Usage/DirUsageSniff.php 
b/MediaWiki/Sniffs/Usage/DirUsageSniff.php
index 3890a53..43510ca 100644
--- a/MediaWiki/Sniffs/Usage/DirUsageSniff.php
+++ b/MediaWiki/Sniffs/Usage/DirUsageSniff.php
@@ -15,18 +15,18 @@
        // @codingStandardsIgnoreEnd
        public function register() {
                // As per 
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Other
-               return array( T_STRING );
+               return [ T_STRING ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
                $tokens = $phpcsFile->getTokens();
 
-               $ignore = array(
+               $ignore = [
                                   T_DOUBLE_COLON    => true,
                                   T_OBJECT_OPERATOR => true,
                                   T_FUNCTION        => true,
                                   T_CONST           => true,
-                                 );
+                                 ];
 
                // Check if the function is dirname()
                if ( strtolower( $tokens[$stackPtr]['content'] ) != "dirname" ) 
{
diff --git a/MediaWiki/Sniffs/Usage/GotoUsageSniff.php 
b/MediaWiki/Sniffs/Usage/GotoUsageSniff.php
index dd081ee..7ca1da6 100644
--- a/MediaWiki/Sniffs/Usage/GotoUsageSniff.php
+++ b/MediaWiki/Sniffs/Usage/GotoUsageSniff.php
@@ -7,9 +7,9 @@
        // @codingStandardsIgnoreEnd
        public function register() {
                // As per 
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Other
-               return array(
+               return [
                        T_GOTO
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
diff --git a/MediaWiki/Sniffs/VariableAnalysis/UnusedGlobalVariablesSniff.php 
b/MediaWiki/Sniffs/VariableAnalysis/UnusedGlobalVariablesSniff.php
index 688dbb5..566ee54 100644
--- a/MediaWiki/Sniffs/VariableAnalysis/UnusedGlobalVariablesSniff.php
+++ b/MediaWiki/Sniffs/VariableAnalysis/UnusedGlobalVariablesSniff.php
@@ -8,7 +8,7 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array( T_FUNCTION );
+               return [ T_FUNCTION ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -21,10 +21,10 @@
                $scopeCloser = $tokens[$stackPtr]['scope_closer'];
 
                $globalLine = 0;
-               $globalVariables = array();
-               $otherVariables = array();
-               $matches = array();
-               $strVariables = array();
+               $globalVariables = [];
+               $otherVariables = [];
+               $matches = [];
+               $strVariables = [];
 
                for ( $i = $scopeOpener; $i < $scopeCloser; $i++ ) {
                        if ( array_key_exists( $tokens[$i]['type'], 
PHP_CodeSniffer_Tokens::$emptyTokens ) ) {
@@ -34,7 +34,7 @@
                                $globalLine = $tokens[$i]['line'];
                        }
                        if ( $tokens[$i]['type'] === 'T_VARIABLE' && 
$tokens[$i]['line'] == $globalLine ) {
-                               $globalVariables[] = array( 
$tokens[$i]['content'], $i );
+                               $globalVariables[] = [ $tokens[$i]['content'], 
$i ];
                        }
                        if ( $tokens[$i]['type'] === 'T_VARIABLE' && 
$tokens[$i]['line'] != $globalLine ) {
                                $otherVariables[$tokens[$i]['content']] = null;
diff --git a/MediaWiki/Sniffs/WhiteSpace/MultipleEmptyLinesSniff.php 
b/MediaWiki/Sniffs/WhiteSpace/MultipleEmptyLinesSniff.php
index 081c4fa..baae0fa 100644
--- a/MediaWiki/Sniffs/WhiteSpace/MultipleEmptyLinesSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/MultipleEmptyLinesSniff.php
@@ -7,9 +7,9 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array(
+               return [
                        T_WHITESPACE
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -32,7 +32,7 @@
                                                $error,
                                                $stackPtr,
                                                'MultipleEmptyLines',
-                                               array( $lines )
+                                               [ $lines ]
                                        );
                                        if ( $fix === true ) {
                                                
$phpcsFile->fixer->beginChangeset();
diff --git a/MediaWiki/Sniffs/WhiteSpace/SpaceAfterControlStructureSniff.php 
b/MediaWiki/Sniffs/WhiteSpace/SpaceAfterControlStructureSniff.php
index bab1c5c..8a54e45 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceAfterControlStructureSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceAfterControlStructureSniff.php
@@ -8,14 +8,14 @@
        // @codingStandardsIgnoreEnd
        public function register() {
                // Per 
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Spaces
-               return array(
+               return [
                        T_IF,
                        T_WHILE,
                        T_FOR,
                        T_FOREACH,
                        T_SWITCH,
                        T_CATCH,
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
@@ -23,7 +23,7 @@
                $nextToken = $tokens[$stackPtr + 1];
                if ( $nextToken['code'] !== T_WHITESPACE || 
$nextToken['content'] !== ' ' ) {
                        $error = 'Control structure "%s" must be followed by a 
single space';
-                       $data = array( $tokens[$stackPtr]['content'] );
+                       $data = [ $tokens[$stackPtr]['content'] ];
                        $fix = $phpcsFile->addFixableWarning( $error, 
$stackPtr, 'Incorrect', $data );
                        if ( $fix === true ) {
                                if ( $nextToken['code'] !== T_WHITESPACE ) {
diff --git a/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeSingleLineCommentSniff.php 
b/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeSingleLineCommentSniff.php
index 1d3d851..0a4a7a4 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeSingleLineCommentSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeSingleLineCommentSniff.php
@@ -7,9 +7,9 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array(
+               return [
                        T_COMMENT
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
diff --git a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php 
b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
index 8986b34..92cd9d9 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
@@ -13,10 +13,10 @@
        implements PHP_CodeSniffer_Sniff {
        // @codingStandardsIgnoreEnd
        public function register() {
-               return array(
+               return [
                        T_OPEN_PARENTHESIS,
                        T_CLOSE_PARENTHESIS,
-               );
+               ];
        }
 
        public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
diff --git a/MediaWiki/Tests/MediaWikiStandardTest.php 
b/MediaWiki/Tests/MediaWikiStandardTest.php
index b422ac9..ae028a6 100644
--- a/MediaWiki/Tests/MediaWikiStandardTest.php
+++ b/MediaWiki/Tests/MediaWikiStandardTest.php
@@ -43,7 +43,7 @@
         * Run simple syntax checks, if the filename ends with pass.php - 
expect it to pass
         */
        public static function testProvider() {
-               $tests = array();
+               $tests = [];
 
                $standard = dirname( __DIR__ );
                $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . 
'/files' );
@@ -55,11 +55,11 @@
 
                        $file = $dir->getPathname();
                        $expectPass = ( substr( $file, -8 ) === 'pass.php' );
-                       $tests[] = array(
+                       $tests[] = [
                                $file,
                                $standard,
                                $expectPass
-                       );
+                       ];
                }
                return $tests;
        }
diff --git 
a/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax_pass.php 
b/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax_pass.php
index 602d775..1f7be98 100644
--- a/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax_pass.php
+++ b/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax_pass.php
@@ -8,7 +8,7 @@
        echo $i;
 }
 
-foreach ( array( 1, 2, 3 ) as $i ) {
+foreach ( [ 1, 2, 3 ] as $i ) {
        echo $i;
 }
 
diff --git 
a/MediaWiki/Tests/files/ControlStructures/assignment_in_control_structures_pass.php
 
b/MediaWiki/Tests/files/ControlStructures/assignment_in_control_structures_pass.php
index b9228c7..dbca3c5 100644
--- 
a/MediaWiki/Tests/files/ControlStructures/assignment_in_control_structures_pass.php
+++ 
b/MediaWiki/Tests/files/ControlStructures/assignment_in_control_structures_pass.php
@@ -4,7 +4,7 @@
 
 } elseif ( $foo === 1 ) {
 
-} elseif ( $foo === array( 1 => 0 ) ) {
+} elseif ( $foo === [ 1 => 0 ] ) {
 
 } elseif ( $foo > 1 || $bar < 1 ) {
 
diff --git a/MediaWiki/Tests/files/NamingConventions/wf_namespace_pass.php 
b/MediaWiki/Tests/files/NamingConventions/wf_namespace_pass.php
index 09d31d3..f0ce08e 100644
--- a/MediaWiki/Tests/files/NamingConventions/wf_namespace_pass.php
+++ b/MediaWiki/Tests/files/NamingConventions/wf_namespace_pass.php
@@ -4,5 +4,5 @@
 
 // Doesn't start with "wf"
 function baz() {
-       $a = array();
+       $a = [];
 }
diff --git a/MediaWiki/Tests/files/WhiteSpace/space_before_parens_pass.php 
b/MediaWiki/Tests/files/WhiteSpace/space_before_parens_pass.php
index 3b70ff3..8b8cfbd 100644
--- a/MediaWiki/Tests/files/WhiteSpace/space_before_parens_pass.php
+++ b/MediaWiki/Tests/files/WhiteSpace/space_before_parens_pass.php
@@ -1,5 +1,5 @@
 <?php
 function wfBar() {
        wfFoo();
-       $a = array();
+       $a = [];
 }
diff --git a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis_pass.php 
b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis_pass.php
index 9a20aca..39c84bf 100644
--- a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis_pass.php
+++ b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis_pass.php
@@ -1,10 +1,10 @@
 <?php
 
 function wfFooFoo( $arg, $arg2 ) {
-       $foo = array(
+       $foo = [
                // a comment
                'foo' => 'bar',
                // 'foo' => 'baz',
-       );
+       ];
        (int)$arg->bar();
 }
diff --git a/MediaWiki/Tests/files/generic_pass.php 
b/MediaWiki/Tests/files/generic_pass.php
index 57263cc..444c572 100644
--- a/MediaWiki/Tests/files/generic_pass.php
+++ b/MediaWiki/Tests/files/generic_pass.php
@@ -16,18 +16,18 @@
        }
 }
 
-$wgAutopromote = array(
-       'autoconfirmed' => array( '&',
-               array( APCOND_EDITCOUNT, &$wgAutoConfirmCount ),
-               array( APCOND_AGE, &$wgAutoConfirmAge ),
-       ),
-);
+$wgAutopromote = [
+       'autoconfirmed' => [ '&',
+               [ APCOND_EDITCOUNT, &$wgAutoConfirmCount ],
+               [ APCOND_AGE, &$wgAutoConfirmAge ],
+       ],
+];
 
-$namespaceNames = array(
+$namespaceNames = [
        NS_MEDIA            => 'Media',
        NS_SPECIAL          => 'Special',
        NS_MAIN             => '',
-);
+];
 
 class FooBar extends BarBaz implements SomethingSomewhere {
 
@@ -77,8 +77,8 @@
 
                $wgBarBarBar->dobar(
                        Xml::fieldset( wfMessage( 'importinterwiki' )->text() ) 
.
-                       Xml::openElement( 'form', array( 'method' => 'post', 
'action' => $par,
-                               'id' => 'mw-import-interwiki-form' ) ) .
+                       Xml::openElement( 'form', [ 'method' => 'post', 
'action' => $par,
+                               'id' => 'mw-import-interwiki-form' ] ) .
                        wfMessage( 'import-interwiki-text' )->parse() .
                        Xml::hidden( 'action', 'submit' ) .
                        Xml::hidden( 'source', 'interwiki' ) .
@@ -91,11 +91,11 @@
        }
 
        private function someFunction( FooBar $baz ) {
-               $foo = array(
+               $foo = [
                        $baz,
                        'memememememememee',
-               );
-               $cat = array_merge( $foo, array( 'barn', 'door' ) );
+               ];
+               $cat = array_merge( $foo, [ 'barn', 'door' ] );
                return $cat;
        }
 }
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index c4a533f..17a7aa8 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -9,6 +9,8 @@
 
        <description>A coding standard for MediaWiki.</description>
 
+       <rule ref="Generic.Arrays.DisallowLongArraySyntax" />
+
        <rule ref="Generic.Classes.DuplicateClassName" />
        <!-- Some people likes else { /** comment */ }
        <rule ref="Generic.CodeAnalysis.EmptyStatement" />
diff --git a/TestHelper.php b/TestHelper.php
index d0f61c6..4dfbcc3 100644
--- a/TestHelper.php
+++ b/TestHelper.php
@@ -54,13 +54,13 @@
                        defined( 'PHP_CodeSniffer::VERSION' ) &&
                        version_compare( PHP_CodeSniffer::VERSION, '1.5.0' ) != 
-1
                ) {
-                       $standard = array( $standard );
+                       $standard = [ $standard ];
                }
-               $options = array(
+               $options = [
                                'encoding' => 'utf-8',
-                               'files' => array( $file ),
+                               'files' => [ $file ],
                                'standard' => $standard,
-                       ) + $defaults;
+                       ] + $defaults;
 
                // New PHPCS has a strange issue where the method arguments
                // are not stored on the instance causing weird errors.

-- 
To view, visit https://gerrit.wikimedia.org/r/269612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a805d7e43b92ccde87d244a17b96b0f1be332c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to