Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/270264
Change subject: Make $wgLocalStylePath the same as $wgStylePath
......................................................................
Make $wgLocalStylePath the same as $wgStylePath
The other /static urls SHOULD be relative, whereas this one MUST be relative.
Added a comment to document this fact.
We honour this SHOULD (since we don't use bits.wikimedia.org anymore),
however these variables still varied for no particular reason (/static vs
/w/static).
Remove this unimportant difference to make maintenance easier (and improve
caching).
Change-Id: I1d5af9dde8834202372dbf39480df6adc33a3878
---
M wmf-config/CommonSettings.php
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/64/270264/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 6919cd3..12d7a17 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -227,12 +227,15 @@
$wgScript = "{$wgScriptPath}/index.php";
$wgRedirectScript = "{$wgScriptPath}/redirect.php";
$wgLoadScript = "{$wgScriptPath}/load.php";
-$wgLocalStylePath = "{$wgScriptPath}/static/$wmgVersionNumber/skins";
-// Don't include a hostname in these urls (T106966, T112646)
+// Don't include a hostname in these urls
+// - Goes wrong otherwise on mobile web (T106966, T112646)
+// - Improves performance by leveraging HTTP/2
+// - $wgLocalStylePath MUST be relative
$wgResourceBasePath = "/static/{$wmgVersionNumber}";
$wgExtensionAssetsPath = "{$wgResourceBasePath}/extensions";
$wgStylePath = "{$wgResourceBasePath}/skins";
+$wgLocalStylePath = $wgStylePath;
// Deprecated
$wgStyleSheetPath = $wgStylePath;
--
To view, visit https://gerrit.wikimedia.org/r/270264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d5af9dde8834202372dbf39480df6adc33a3878
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
