Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/270291
Change subject: Add a comment about $( '<input type="file">' ).prop( 'disabled' ) ...................................................................... Add a comment about $( '<input type="file">' ).prop( 'disabled' ) This was a massive WTF moment and I was going to delete this code as obviously broken until I blamed it and it turns out that Brion says it works. (Probably, unless the attr->prop change broke it.) Change-Id: I63b1b0ea8f2fcdc2f51b021f246d1eaa6ea49c0c --- M resources/mw.UploadWizardUploadInterface.js 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/91/270291/1 diff --git a/resources/mw.UploadWizardUploadInterface.js b/resources/mw.UploadWizardUploadInterface.js index c11f1b0..a77979e 100644 --- a/resources/mw.UploadWizardUploadInterface.js +++ b/resources/mw.UploadWizardUploadInterface.js @@ -91,6 +91,7 @@ .append( this.filenameCtrl ) .get( 0 ); + // While this looks extremely unlikely to be right, it actually is. Blame Apple. T34328#364508 if ( $( '<input type="file">' ).prop( 'disabled' ) ) { $( '#mwe-upwiz-stepdiv-file' ).replaceWith( $( '<span/>' ) -- To view, visit https://gerrit.wikimedia.org/r/270291 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63b1b0ea8f2fcdc2f51b021f246d1eaa6ea49c0c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits