jenkins-bot has submitted this change and it was merged.
Change subject: Change order of text highlight CAB actions
......................................................................
Change order of text highlight CAB actions
The tooltip now points to the wrong CAB action since we introduced
the new Wiktionary definition action. This patch simply changes the
order of the actions and now the tooltip points to the correct one.
Bug: T124836
Change-Id: I17a24c3dae4ace4e758bcc2c2400ee80a3d6ad00
---
M app/src/main/res/menu/menu_text_select.xml
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Sniedzielski: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/res/menu/menu_text_select.xml
b/app/src/main/res/menu/menu_text_select.xml
index c9ed178..4548566 100644
--- a/app/src/main/res/menu/menu_text_select.xml
+++ b/app/src/main/res/menu/menu_text_select.xml
@@ -7,15 +7,15 @@
android:icon="?actionModeCopyDrawable"
app:showAsAction="ifRoom" />
+ <item android:id="@+id/menu_text_select_share"
+ android:title="@string/menu_text_select_share"
+ android:icon="?actionModeShareDrawable"
+ app:showAsAction="ifRoom" />
+
<item android:id="@+id/menu_text_select_define"
android:title="@string/menu_text_select_define"
android:icon="@drawable/define_light"
android:visible="false"
- app:showAsAction="ifRoom" />
-
- <item android:id="@+id/menu_text_select_share"
- android:title="@string/menu_text_select_share"
- android:icon="?actionModeShareDrawable"
app:showAsAction="ifRoom" />
</menu>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/270243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17a24c3dae4ace4e758bcc2c2400ee80a3d6ad00
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
