jenkins-bot has submitted this change and it was merged.

Change subject: Element, ListToolGroup: Add some missing documentation
......................................................................


Element, ListToolGroup: Add some missing documentation

Change-Id: I0fcc196e6ea1d1c51b4717e9085f161f4cec1979
---
M src/Element.js
M src/toolgroups/ListToolGroup.js
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/Element.js b/src/Element.js
index 619477a..b2f5ebd 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -828,6 +828,8 @@
 
 /**
  * Get closest scrollable container.
+ *
+ * @return {HTMLElement} Closest scrollable container
  */
 OO.ui.Element.prototype.getClosestScrollableElementContainer = function () {
        return OO.ui.Element.static.getClosestScrollableContainer( 
this.$element[ 0 ] );
@@ -857,6 +859,7 @@
  * Scroll element into view.
  *
  * @param {Object} [config] Configuration options
+ * @return {jQuery.Promise} Promise which resolves when the scroll is complete
  */
 OO.ui.Element.prototype.scrollElementIntoView = function ( config ) {
        return OO.ui.Element.static.scrollIntoView( this.$element[ 0 ], config 
);
diff --git a/src/toolgroups/ListToolGroup.js b/src/toolgroups/ListToolGroup.js
index ef2d630..5db85b9 100644
--- a/src/toolgroups/ListToolGroup.js
+++ b/src/toolgroups/ListToolGroup.js
@@ -154,6 +154,11 @@
        this.updateCollapsibleState();
 };
 
+/**
+ * Get the expand/collapse tool for this group
+ *
+ * @return {OO.ui.Tool} Expand collapse tool
+ */
 OO.ui.ListToolGroup.prototype.getExpandCollapseTool = function () {
        var ExpandCollapseTool;
        if ( this.expandCollapseTool === undefined ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/270492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fcc196e6ea1d1c51b4717e9085f161f4cec1979
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to