Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/270497
Change subject: build: Enable jscs jsDoc rule 'checkAnnotations' and make pass
......................................................................
build: Enable jscs jsDoc rule 'checkAnnotations' and make pass
"jsduck5" as in the wikimedia preset, with some extras;
fixed some annotations with trailing colon.
Change-Id: I0cb3cf86ed37bb2321ef4c9d5c3d6a91cba07aa7
---
M .jscsrc
M client/resources/wikibase.client.linkitem.init.js
M lib/tests/qunit/data/testrunner.js
M repo/resources/wikibase.EntityInitializer.js
4 files changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/97/270497/1
diff --git a/.jscsrc b/.jscsrc
index d341dd1..04201a6 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -12,7 +12,19 @@
"requireVarDeclFirst": null,
"jsDoc": {
// what we don't yet follow is commented out
- //"checkAnnotations": "jsduck5",
+ "checkAnnotations": {
+ "preset": "jsduck5",
+ "extra": {
+ "TODO:": "some",
+ "licence": "some",
+ "license": "some",
+ "note:": "some",
+ "option": "some",
+ "see": "some",
+ "todo": "some",
+ "triggers": "some"
+ }
+ },
"checkParamNames": true,
"requireParamTypes": true,
"checkRedundantParams": true,
diff --git a/client/resources/wikibase.client.linkitem.init.js
b/client/resources/wikibase.client.linkitem.init.js
index abf3dfc..3184c9d 100644
--- a/client/resources/wikibase.client.linkitem.init.js
+++ b/client/resources/wikibase.client.linkitem.init.js
@@ -4,7 +4,7 @@
* @since 0.4
*
* @licence GNU GPL v2+
- * @author: Marius Hoch < [email protected] >
+ * @author Marius Hoch < [email protected] >
*/
( function( mw, $ ) {
'use strict';
diff --git a/lib/tests/qunit/data/testrunner.js
b/lib/tests/qunit/data/testrunner.js
index 8c042bc..5b55838 100644
--- a/lib/tests/qunit/data/testrunner.js
+++ b/lib/tests/qunit/data/testrunner.js
@@ -16,7 +16,7 @@
*
* @param {Object} custom test environment variables according to
QUnit.newMwEnvironment
*
- * @example:
+ * @example
* <code>
* module( ..., newWbEnvironment() );
*
diff --git a/repo/resources/wikibase.EntityInitializer.js
b/repo/resources/wikibase.EntityInitializer.js
index 3fd3de9..54e5922 100644
--- a/repo/resources/wikibase.EntityInitializer.js
+++ b/repo/resources/wikibase.EntityInitializer.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
*
* @author Adrian Lang <[email protected]>
- * @author: H. Snater < [email protected] >
+ * @author H. Snater < [email protected] >
*/
( function( $, mw, wb ) {
'use strict';
--
To view, visit https://gerrit.wikimedia.org/r/270497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cb3cf86ed37bb2321ef4c9d5c3d6a91cba07aa7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
