jenkins-bot has submitted this change and it was merged.
Change subject: Generate bundled page-linked notifications in test script
......................................................................
Generate bundled page-linked notifications in test script
Change-Id: I6414c920e3a29ea5048819433aa86f41d8f54e69
---
M maintenance/generateSampleNotifications.php
1 file changed, 22 insertions(+), 7 deletions(-)
Approvals:
Catrope: Looks good to me, approved
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/generateSampleNotifications.php
b/maintenance/generateSampleNotifications.php
index 4ae5515..a1ab846 100644
--- a/maintenance/generateSampleNotifications.php
+++ b/maintenance/generateSampleNotifications.php
@@ -138,13 +138,8 @@
}
private function generatePageLink( User $user, User $agent ) {
- $pageBeingMentioned = $this->generateNewPageTitle();
- $this->addToPageContent( $pageBeingMentioned, $user, "this is a
new page" );
-
- $pageMentioning = $this->generateNewPageTitle();
- $content = "checkout
[[{$pageBeingMentioned->getPrefixedText()}]]!";
- $this->output( "{$agent->getName()} is linking to
{$pageBeingMentioned->getPrefixedText()} from
{$pageMentioning->getPrefixedText()}\n" );
- $this->addToPageContent( $pageMentioning, $agent, $content );
+ $this->generateOnePageLink( $user, $agent );
+ $this->generateMultiplePageLinks( $user, $agent );
}
private function generateNewPageTitle() {
@@ -256,7 +251,27 @@
),
)
);
+ }
+ private function generateOnePageLink( User $user, User $agent ) {
+ $pageBeingLinked = $this->generateNewPageTitle();
+ $this->addToPageContent( $pageBeingLinked, $user, "this is a
new page" );
+
+ $pageLinking = $this->generateNewPageTitle();
+ $content = "checkout
[[{$pageBeingLinked->getPrefixedText()}]]!";
+ $this->output( "{$agent->getName()} is linking to
{$pageBeingLinked->getPrefixedText()} from {$pageLinking->getPrefixedText()}\n"
);
+ $this->addToPageContent( $pageLinking, $agent, $content );
+ }
+
+ private function generateMultiplePageLinks( User $user, User $agent ) {
+ $pageBeingLinked = $this->generateNewPageTitle();
+ $this->addToPageContent( $pageBeingLinked, $user, "this is a
new page" );
+
+ $content = "checkout
[[{$pageBeingLinked->getPrefixedText()}]]!";
+ $this->output( "{$agent->getName()} is linking to
{$pageBeingLinked->getPrefixedText()} from multiple pages\n" );
+ $this->addToPageContent( $this->generateNewPageTitle(), $agent,
$content );
+ $this->addToPageContent( $this->generateNewPageTitle(), $agent,
$content );
+ $this->addToPageContent( $this->generateNewPageTitle(), $agent,
$content );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/268172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6414c920e3a29ea5048819433aa86f41d8f54e69
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
