jenkins-bot has submitted this change and it was merged.
Change subject: Add 2 FIXMEs about confusingly named functions
......................................................................
Add 2 FIXMEs about confusingly named functions
With the roll-out of the Gadget namespace, these are going to be
especially misleading and likely to cause bugs.
Change-Id: I61f1f56762711fab173bbc54d110a7c48604d464
---
M includes/Title.php
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/Title.php b/includes/Title.php
index 55c7179..da0efee 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1261,6 +1261,7 @@
* show "inactive" CSS or JS.
*
* @return bool
+ * @todo FIXME: Rename to isSiteConfigPage() and remove deprecated hook
*/
public function isCssOrJsPage() {
$isCssOrJsPage = NS_MEDIAWIKI == $this->mNamespace
@@ -1279,6 +1280,7 @@
/**
* Is this a .css or .js subpage of a user page?
* @return bool
+ * @todo FIXME: Rename to isUserConfigPage()
*/
public function isCssJsSubpage() {
return ( NS_USER == $this->mNamespace && $this->isSubpage()
--
To view, visit https://gerrit.wikimedia.org/r/269348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61f1f56762711fab173bbc54d110a7c48604d464
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
