Phedenskog has uploaded a new change for review.
https://gerrit.wikimedia.org/r/270725
Change subject: Collect Navigation Timing metrics with higher sane values
......................................................................
Collect Navigation Timing metrics with higher sane values
In the current version we only use metrics from the Navigation
Timing API that are < 60 s. That could be too small for mobile on
slow connections.
Lets collect metrics on the side that are < 180 s and compare that
with the current metrics. We keep how we collect metrics exactly
as before, so we are able to compare the difference.
This is an experiment. Lets analyze the numbers we get and decide
if we should keep it ( = make 180s default) or continue with 60s.
Bug: T125381
Change-Id: Ifc8d5a828f0d08c3de8c5e9bc84a8d2fd1687540
---
M modules/webperf/files/navtiming.py
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/25/270725/1
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index b43a93f..57defb5 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -113,6 +113,8 @@
def is_sane(value):
return isinstance(value, int) and value > 0 and value < 60000
+def is_sane_experimental(value):
+ return isinstance(value, int) and value > 0 and value < 180000
@handles('SaveTiming')
def handle_save_timing(meta):
@@ -173,6 +175,7 @@
for metric, value in metrics.items():
prefix = 'frontend.navtiming'
+ prefix_experimental = 'frontend.navtiming-experimental'
if is_sane(value):
dispatch_stat(prefix, metric, site, auth, value)
@@ -184,6 +187,16 @@
if ua:
dispatch_stat(prefix, ua, metric, site, value)
+ if is_sane_experimental(value):
+ dispatch_stat(prefix_experimental, metric, site, auth, value)
+ dispatch_stat(prefix_experimental, metric, site, 'overall', value)
+ dispatch_stat(prefix_experimental, metric, 'overall', value)
+
+ prefix_experimental = prefix_experimental + '.by_platform'
+ ua = parse_ua(meta['userAgent'])
+ if ua:
+ dispatch_stat(prefix_experimental, ua, metric, site, value)
+
for meta in iter(zsock.recv_json, ''):
f = handlers.get(meta['schema'])
--
To view, visit https://gerrit.wikimedia.org/r/270725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc8d5a828f0d08c3de8c5e9bc84a8d2fd1687540
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Phedenskog <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
