jenkins-bot has submitted this change and it was merged.
Change subject: Reset window title after termbox stopediting event
......................................................................
Reset window title after termbox stopediting event
The 2nd event is triggered when cancel is clicked, but does not send
a language code (it can't). It sends a boolean instead.
Change-Id: I9bc0aeeb75529ded2fa210c68db6ee83764d2136
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 0b5b2b4..336bb8f 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -367,14 +367,16 @@
if ( canEdit ) {
$entityview
.on( 'entitytermsviewchange
entitytermsviewafterstopediting', function( event, lang ) {
- if ( lang !== mw.config.get( 'wgUserLanguage' )
) {
+ var userLanguage = mw.config.get(
'wgUserLanguage' );
+
+ if ( typeof lang === 'string' && lang !==
userLanguage ) {
return;
}
var $entitytermsview = $( event.target ),
entitytermsview =
$entitytermsview.data( 'entitytermsview' ),
fingerprint = entitytermsview.value(),
- label = fingerprint.getLabelFor( lang ),
+ label = fingerprint.getLabelFor(
userLanguage ),
isEmpty = !label || label.getText() ===
'';
$( 'title' ).text(
--
To view, visit https://gerrit.wikimedia.org/r/270730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bc0aeeb75529ded2fa210c68db6ee83764d2136
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
