jenkins-bot has submitted this change and it was merged.
Change subject: Removing obsolete html Width attribute
......................................................................
Removing obsolete html Width attribute
Deprecated width attribute has been removed from
Sandbox.php and CSS has been used instead by applying
the same style using corresponding id's.
Bug: T126967
Change-Id: Iefa6e48788181c0612c98d0d6ae19517ae5732e7
---
M includes/Sandbox.php
M styles/common.less
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Yurik: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Sandbox.php b/includes/Sandbox.php
index b67be6e..057728e 100644
--- a/includes/Sandbox.php
+++ b/includes/Sandbox.php
@@ -35,9 +35,9 @@
$graphHtml = Html::rawElement( 'div', $attr, '' );
// FIXME: make this textarea readonly (but text should be
selectable)
- $logHtml = '<div><pre id="mw-graph-log" width="100%"
dir="ltr"></pre></div>';
+ $logHtml = '<div><pre id="mw-graph-log" dir="ltr"></pre></div>';
$specHtml = '<div><textarea tabindex="1" accesskey=","
id="wpTextbox1" cols="80" rows="40" style="" lang="en" dir="ltr"
name="wpTextbox1" class="webfonts-changed"></textarea></div>';
- $jsonHtml = '<div><pre id="mw-graph-json"
width="100%"></pre></div>';
+ $jsonHtml = '<div><pre id="mw-graph-json"></pre></div>';
$out->addHTML( Html::rawElement( 'div', array( 'id' =>
'mw-graph-sandbox' ),
Html::rawElement( 'div', array( 'id' => 'mw-graph-left'
), $graphHtml . $logHtml ) .
diff --git a/styles/common.less b/styles/common.less
index d01d405..6e864db 100644
--- a/styles/common.less
+++ b/styles/common.less
@@ -155,4 +155,8 @@
}
}
+ /* Set graph width */
+ #mw-graph-log, #mw-graph-json {
+ width: 100%;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/270733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa6e48788181c0612c98d0d6ae19517ae5732e7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Graph
Gerrit-Branch: master
Gerrit-Owner: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: He7d3r <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
