John Erling Blad has submitted this change and it was merged. Change subject: Put EntityId parsing code into its own class ......................................................................
Put EntityId parsing code into its own class Got rid of lots of evil stuff :) Change-Id: Icb9f02869a818756972b64f7bff392ce976fa2a6 --- M lib/RELEASE-NOTES M lib/WikibaseLib.hooks.php M lib/WikibaseLib.php M lib/includes/LibRegistry.php M lib/includes/entity/Entity.php M lib/includes/entity/EntityId.php M lib/includes/item/Item.php A lib/includes/parsers/EntityIdParser.php M lib/includes/property/Property.php M lib/includes/query/Query.php M lib/tests/phpunit/entity/EntityIdTest.php A lib/tests/phpunit/parsers/EntityIdParserTest.php M repo/RELEASE-NOTES M repo/includes/api/ApiGetEntities.php M repo/includes/api/ApiModifyEntity.php M repo/includes/content/EntityHandler.php M repo/includes/content/ItemHandler.php M repo/includes/content/PropertyHandler.php M repo/includes/content/QueryHandler.php M repo/tests/phpunit/includes/ItemViewTest.php M repo/tests/phpunit/includes/api/ApiEditEntityTest.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php 22 files changed, 346 insertions(+), 321 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42893 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb9f02869a818756972b64f7bff392ce976fa2a6 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
