Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/270779
Change subject: Send correct event logging languageButtonTappedBucket value
......................................................................
Send correct event logging languageButtonTappedBucket value
When localStorage is available and when the user has not tapped on
the language switcher button before, send '0 taps' as the value of
`languageButtonTappedBucket` of Schema:MobileWebLanguageSwitcher.
If localStorage is not available send 'unknown' as before.
Bug: T126818
Change-Id: I7e1e29056943ba03aee28462161a691661f0787c
---
M resources/skins.minerva.scripts/init.js
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/79/270779/1
diff --git a/resources/skins.minerva.scripts/init.js
b/resources/skins.minerva.scripts/init.js
index 437c147..dea0dd3 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -111,14 +111,19 @@
name: 'languages'
} );
- // when local storage is not available or when
the key has not been previously saved
- if ( previousTapCount === false ||
previousTapCount === null ) {
- tapCountBucket = 'unknown';
+ // when local storage is not available ...
+ if ( previousTapCount === false ) {
previousTapCount = 0;
+ tapCountBucket = 'unknown';
+ // ... or when the key has not been previously
saved
+ } else if ( previousTapCount === null ) {
+ previousTapCount = 0;
+ tapCountBucket =
getLanguageButtonTappedBucket( previousTapCount );
} else {
previousTapCount = parseInt(
previousTapCount, 10 );
tapCountBucket =
getLanguageButtonTappedBucket( previousTapCount );
}
+
settings.save(
'mobile-language-button-tap-count', previousTapCount + 1 );
schemaMobileWebLanguageSwitcher.log( {
event: 'languageButtonTap',
--
To view, visit https://gerrit.wikimedia.org/r/270779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e1e29056943ba03aee28462161a691661f0787c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
