Jeroen De Dauw has submitted this change and it was merged. Change subject: (minor) Snak.toJSON() now uses 'snaktype' instead of 'type' for snaktype ......................................................................
(minor) Snak.toJSON() now uses 'snaktype' instead of 'type' for snaktype Also updated tests. This has been wrong JSON generated before since the server side gave the type as 'snaktype' field some time already and also the wb.Snak.newFromJSON() JavaScript function assumes 'snaktype'. Change-Id: I52dc89b6bdcb389c23fabe0420d7601e1788d04a --- M lib/resources/wikibase.datamodel/wikibase.Snak.js M lib/resources/wikibase.store/wikibase.Api.js M lib/tests/qunit/wikibase.datamodel/Wikibase.snak.tests.js 3 files changed, 15 insertions(+), 5 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42980 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52dc89b6bdcb389c23fabe0420d7601e1788d04a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
