Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271007
Change subject: Update Mapbox to 3.2.0
......................................................................
Update Mapbox to 3.2.0
The only breaking change seems to be renaming of the "Sprite" class to
"Icon". Otherwise seems to be working identically on all devices I've
tested.
Note: this release still doesn't contain arm64 native libraries.
Bug: T126102
Change-Id: I5ab68630a716455e2798291bd48c9708b72d9814
---
M app/build.gradle
M app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/07/271007/1
diff --git a/app/build.gradle b/app/build.gradle
index f5638e7..7d526c0 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -177,7 +177,7 @@
compile 'com.github.ryanjohn1:onboarding:1.0.3'
compile 'com.jakewharton:butterknife:7.0.1'
compile 'com.jakewharton:disklrucache:2.0.2'
- compile('com.mapbox.mapboxsdk:mapbox-android-sdk:2.3.0@aar') {
+ compile('com.mapbox.mapboxsdk:mapbox-android-sdk:3.2.0@aar') {
transitive = true
}
compile 'net.hockeyapp.android:HockeySDK:3.7.0'
diff --git a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
index 847dc59..585eb36 100644
--- a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
+++ b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
@@ -12,7 +12,7 @@
import com.mapbox.mapboxsdk.annotations.Marker;
import com.mapbox.mapboxsdk.annotations.MarkerOptions;
-import com.mapbox.mapboxsdk.annotations.Sprite;
+import com.mapbox.mapboxsdk.annotations.Icon;
import com.mapbox.mapboxsdk.constants.MyLocationTracking;
import com.mapbox.mapboxsdk.geometry.LatLng;
import com.mapbox.mapboxsdk.geometry.LatLngZoom;
@@ -48,7 +48,7 @@
private MapView mapView;
- private Sprite markerIconPassive;
+ private Icon markerIconPassive;
private Site site;
private NearbyResult lastResult;
@@ -69,7 +69,7 @@
mapView = (MapView) rootView.findViewById(R.id.mapview);
mapView.setAccessToken(getString(R.string.mapbox_public_token));
- markerIconPassive =
mapView.getSpriteFactory().fromResource(R.drawable.ic_map_marker);
+ markerIconPassive =
mapView.getIconFactory().fromResource(R.drawable.ic_map_marker);
// TODO: pass savedInstanceState into mapView.onCreate once the
MapView starts managing
// runtime permissions in a better way. This way, the MapView will
start uninitialized
--
To view, visit https://gerrit.wikimedia.org/r/271007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ab68630a716455e2798291bd48c9708b72d9814
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
