jenkins-bot has submitted this change and it was merged.
Change subject: Don't serve HiDPI thumbs on mobile web
......................................................................
Don't serve HiDPI thumbs on mobile web
Omit 'srcset' attribute from thumbnails on mobile web by setting
$wgResponsiveImages to false. The image quality improvement provided by HiDPI
variants is not enough to warrant the substantial cost to users on mobile
devices on connections that are slow or metered.
Bug: T119797
Change-Id: I5818f0350925b4b17652b75dd31367ec7154eb63
---
M wmf-config/mobile.php
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
BBlack: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wmf-config/mobile.php b/wmf-config/mobile.php
index dd58a6b..f32fcd0 100644
--- a/wmf-config/mobile.php
+++ b/wmf-config/mobile.php
@@ -66,7 +66,12 @@
$wgMFNoMobilePages = $wmgMFNoMobilePages;
$wgHooks['EnterMobileMode'][] = function() {
- global $wgCentralAuthCookieDomain, $wgHooks;
+ global $wgCentralAuthCookieDomain, $wgHooks,
$wgResponsiveImages;
+
+ // Disable responsive images on mobile web (T119797), but not
on apps.
+ if ( !defined( 'MW_API' ) ) {
+ $wgResponsiveImages = false;
+ }
// Hack for T49647
if ( $wgCentralAuthCookieDomain == 'commons.wikimedia.org' ) {
--
To view, visit https://gerrit.wikimedia.org/r/270793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5818f0350925b4b17652b75dd31367ec7154eb63
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
