Divec has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271064
Change subject: Clarify documentation of directionality methods
......................................................................
Clarify documentation of directionality methods
Change-Id: I56056629c4e5bf46d0cc03abd84e468fe56f3388
---
M src/ce/ve.ce.Document.js
M src/ce/ve.ce.Selection.js
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/64/271064/1
diff --git a/src/ce/ve.ce.Document.js b/src/ce/ve.ce.Document.js
index a139254..cd21ba3 100644
--- a/src/ce/ve.ce.Document.js
+++ b/src/ce/ve.ce.Document.js
@@ -290,9 +290,9 @@
};
/**
- * Get the directionality of some range.
+ * Get the block directionality of some range
*
- * Uses the computed CSS direction value of the current node.
+ * Uses the computed CSS direction value of the current node
*
* @method
* @param {ve.Range} range Range
diff --git a/src/ce/ve.ce.Selection.js b/src/ce/ve.ce.Selection.js
index 25a3f97..687379b 100644
--- a/src/ce/ve.ce.Selection.js
+++ b/src/ce/ve.ce.Selection.js
@@ -111,9 +111,11 @@
};
/**
- * Get the text directionality of the selection
+ * Get the block directionality of the selection
*
- * Note: This is the text's directionality, not the direction of the selection
(e.g. ve.Range#isBackwards)
+ * Note: This is not the direction of the selection (e.g.
ve.Range#isBackwards); it is the
+ * computed block-level CSS directionality. The actual directionality at any
point within the
+ * selection depends on both this and the browser's implementation of BIDI
algorithm.
*
* @abstract
* @return {string} 'rtl', 'ltr'
--
To view, visit https://gerrit.wikimedia.org/r/271064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56056629c4e5bf46d0cc03abd84e468fe56f3388
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
