Reedy has submitted this change and it was merged. Change subject: fix wmfDatacenter / wmfRealm scope in IS.php ......................................................................
fix wmfDatacenter / wmfRealm scope in IS.php The wmfRealm is needed to be a global variable in InitialiseSettings.php since that is sometime loaded in a local scope. Example: $ mwscript eval.php --wiki=enwiki > $wgConf->loadFullData(); PHP Notice: Undefined variable: wmfRealm in /data/project/apache/common-local/wmf-config/InitialiseSettings.php on line 12244 Notice: Undefined variable: wmfRealm in /data/project/apache/common-local/wmf-config/InitialiseSettings.php on line 12244 > exit Change-Id: Idbc6a488840b1f2ffd175e121687e3657f697bb9 --- M wmf-config/CommonSettings.php M wmf-config/InitialiseSettings.php 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Anomie: Looks good to me, but someone else must approve Reedy: MaxSem: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/42994 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc6a488840b1f2ffd175e121687e3657f697bb9 Gerrit-PatchSet: 2 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
