jenkins-bot has submitted this change and it was merged. Change subject: Disable Generic.Functions.CallTimePassByReference.NotAllowed ......................................................................
Disable Generic.Functions.CallTimePassByReference.NotAllowed Has false positives when using []-style arrays. Test case included. Bug: T127163 Change-Id: I9a1b370d81de6deb146a3f945b76ab8a2e9d3aaa --- M MediaWiki/Tests/files/generic_pass.php M MediaWiki/ruleset.xml 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/MediaWiki/Tests/files/generic_pass.php b/MediaWiki/Tests/files/generic_pass.php index 444c572..6e1b94e 100644 --- a/MediaWiki/Tests/files/generic_pass.php +++ b/MediaWiki/Tests/files/generic_pass.php @@ -100,4 +100,5 @@ } } +Hooks::run( 'SecondaryDataUpdates', [ $title, $old, $recursive, $parserOutput, &$updates ] ); // This file has a new line at the end! diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml index 17a7aa8..59badae 100644 --- a/MediaWiki/ruleset.xml +++ b/MediaWiki/ruleset.xml @@ -10,6 +10,10 @@ <description>A coding standard for MediaWiki.</description> <rule ref="Generic.Arrays.DisallowLongArraySyntax" /> + <rule ref="Generic.Functions.CallTimePassByReference.NotAllowed"> + <!-- too many false positives, see T127163 --> + <severity>0</severity> + </rule> <rule ref="Generic.Classes.DuplicateClassName" /> <!-- Some people likes else { /** comment */ } -- To view, visit https://gerrit.wikimedia.org/r/271216 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a1b370d81de6deb146a3f945b76ab8a2e9d3aaa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Polybuildr <v.a.ghai...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits