jenkins-bot has submitted this change and it was merged.
Change subject: Remove superflous `background-size` property & make use of
mixing
......................................................................
Remove superflous `background-size` property & make use of mixing
Removing superflous `background-size` property, which is overwritten
few lines below and make use of correspondent mixin in `:checked`
state.
Change-Id: I4f24c84c2f93bd85f495ff74ae21fbc210c18f57
---
M resources/src/mediawiki.ui/components/checkbox.less
M resources/src/mediawiki.ui/components/radio.less
2 files changed, 4 insertions(+), 6 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/checkbox.less
b/resources/src/mediawiki.ui/components/checkbox.less
index d44e5d7..b0fbf51 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -75,8 +75,7 @@
background-position: center center;
background-origin: border-box;
background-repeat: no-repeat;
- .background-size( @checkboxSize - 0.2em, @checkboxSize
- 0.2em );
- background-size: 0 0;
+ .background-size( 0, 0 );
.box-sizing( border-box );
position: absolute;
// align the checkbox to middle of the text
@@ -93,7 +92,7 @@
// when the input is checked, style the label pseudo before
element that followed as a checked checkbox
&:checked + label::before {
- background-size: 100% 100%;
+ .background-size( 100%, 100% );
}
&:active + label::before {
diff --git a/resources/src/mediawiki.ui/components/radio.less
b/resources/src/mediawiki.ui/components/radio.less
index 448390a..53c22b44 100644
--- a/resources/src/mediawiki.ui/components/radio.less
+++ b/resources/src/mediawiki.ui/components/radio.less
@@ -67,8 +67,7 @@
background-origin: border-box;
background-position: center center;
background-repeat: no-repeat;
- .background-size( @radioSize, @radioSize );
- background-size: 0 0;
+ .background-size( 0, 0 );
.box-sizing( border-box );
position: absolute;
left: 0;
@@ -81,7 +80,7 @@
// when the input is checked, style the label pseudo before
element that followed as a checked radio
&:checked + label::before {
- background-size: 100% 100%;
+ .background-size( 100%, 100% );
}
&:active + label::before {
--
To view, visit https://gerrit.wikimedia.org/r/261605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f24c84c2f93bd85f495ff74ae21fbc210c18f57
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
