Trevor Parscal has uploaded a new change for review. Change subject: Major ve.ui rewrite ......................................................................
Major ve.ui rewrite Objectives: * Make the link inspector easier to use * Try to resolve a few bugs (bug 43063, bug 42986) * Stop using jquery.multiSuggest (which didn't really understand annotations) * Better divide MediaWiki specifics from generic implementations Changes: VisualEditor.php, modules/ve/test/index.php, demos/ve/index.php * Updated links to files ve.Registry * Fixed mistake where registry was initialized as an array - this didn't cause any errors because you can add arbitrary properties to an array and use it like any other object ve.Factory * Removed duplicate initialization of registry property * Added entries property, which is an array that's appended to for tracking the order of registrations ve.CommandRegistry * Added mwLink command which opens the mwLink inspector ve.ui.TextInputWidget * Added basic widget class for text inputs ve.ui.TextInputMenuWidget * Added widget that provides a menu of options for a text input widget ve.ui.MWLinkTargetInputWidget * Added MediaWiki specific link target widget ve.ui.MenuWidget * Converted ve.ui.Menu into a widget * Moved the body of onSelect to onMouseUp ve.ui.LinkTargetInputWidget * Added link target widget which adds link annotation functionality to a normal text input ve.ui.InputWidget * Added generic input widget which emits reliable and instant change events and synchronizes a value property with the DOM value ve.ui.Widget * Added base widget class * Widgets can be used in any frame ve.ui.Tool * Fixed line length issues ve.ui.InspectorFactory * Made use of new entries property for factories to select the most recently added inspector if more than one match a given annotation ve.ui.Inspector * Added auto-focus on the first visible input element on open * Moved afterClose event to after re-focus on document on close * Added documentation ve.ui.Frame * Adjusted documentation * Added binding of $$ to the frame context so it can be passed around * Added documentation ve.ui.Context * Added ve.ui.Widget.css to iframes * Updated code as per moving of ve.ui.Menu to ve.ui.MenuWidget * Removed unused positionBelowOverlay method * Added CSS settings to set overlay left and width properties according to context size * Added documentation ve.ui.DropdownTool * Updated code as per moving of ve.ui.Menu to ve.ui.MenuWidget ve.ui.FormatDropdownTool * Added documentation ve.ui.MWLinkButtonTool * Added MediaWiki specific version of ve.ui.LinkButtonTool, which opens the mwLink inspector ve.ui.Widget.css * Added styles for all widgets ve.ui.Tool.css, ve.init.sa.css, ve.init.mw.ViewPageTarget.css, ve.init.mw.ViewPageTarget-apex.css * Updated code as per moving of ve.ui.Menu to ve.ui.MenuWidget ve.ui.Menu.css * Deleted (merged into ve.ui.Widget.css) ve.ui.Menu.css * Deleted suggest styles (no longer used) pending.gif * Added diagonal stripe animation to indicate a pending request to the API ve.ui.MWLinkInspector * Added MediaWiki specific inspector which uses MediaWiki specific annotations and widgets ve.ui.LinkInspector * Removed mw global hint (not needed anymore) * Switched from comparing targets to annotations (since the target text is ambiguous in some situations) * Switched to using input widget, which is configured using a static property * Removed use of jquery.multiSuggest * Moved MediaWiki specifics to their own class (ve.ui.MWLinkInspector) ve.init.mw.ViewPageTarget * Added MediaWiki specific toolbar and command options Change-Id: I859b5871a9d2f17d970c002067c8ff24f3513e9f --- M VisualEditor.php M demos/ve/index.php M modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget-apex.css M modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js M modules/ve/init/sa/styles/ve.init.sa.css M modules/ve/test/index.php M modules/ve/ui/inspectors/ve.ui.LinkInspector.js A modules/ve/ui/inspectors/ve.ui.MWLinkInspector.js A modules/ve/ui/styles/images/pending.gif M modules/ve/ui/styles/ve.ui.Inspector.css D modules/ve/ui/styles/ve.ui.Menu.css M modules/ve/ui/styles/ve.ui.Tool.css A modules/ve/ui/styles/ve.ui.Widget.css A modules/ve/ui/tools/buttons/ve.ui.MWLinkButtonTool.js M modules/ve/ui/tools/dropdowns/ve.ui.FormatDropdownTool.js M modules/ve/ui/tools/ve.ui.DropdownTool.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Frame.js M modules/ve/ui/ve.ui.Inspector.js M modules/ve/ui/ve.ui.InspectorFactory.js D modules/ve/ui/ve.ui.Menu.js M modules/ve/ui/ve.ui.Tool.js A modules/ve/ui/ve.ui.Widget.js A modules/ve/ui/widgets/ve.ui.InputWidget.js A modules/ve/ui/widgets/ve.ui.LinkTargetInputWidget.js A modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js A modules/ve/ui/widgets/ve.ui.MenuWidget.js A modules/ve/ui/widgets/ve.ui.TextInputMenuWidget.js A modules/ve/ui/widgets/ve.ui.TextInputWidget.js M modules/ve/ve.CommandRegistry.js M modules/ve/ve.Factory.js M modules/ve/ve.Registry.js 33 files changed, 1,559 insertions(+), 527 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/28/43028/1 -- To view, visit https://gerrit.wikimedia.org/r/43028 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I859b5871a9d2f17d970c002067c8ff24f3513e9f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
