jenkins-bot has submitted this change and it was merged.
Change subject: Use "self" keyword to refer to own class name
......................................................................
Use "self" keyword to refer to own class name
Change-Id: I7203cfd7189aa5d6bfe11bb867d313bee248d850
---
M api/RunCrossCheck.php
M includes/CrossCheck/Result/CrossCheckResultList.php
M includes/ExternalValidationServices.php
M specials/SpecialExternalDbs.php
4 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/api/RunCrossCheck.php b/api/RunCrossCheck.php
index 8bc75c2..eefcee7 100644
--- a/api/RunCrossCheck.php
+++ b/api/RunCrossCheck.php
@@ -59,9 +59,10 @@
* Creates new instance from global state.
*
* @param ApiMain $main
- * @param $name
+ * @param string $name
* @param string $prefix
- * @return RunCrossCheck
+ *
+ * @return self
*/
public static function newFromGlobalState( ApiMain $main, $name,
$prefix = '' ) {
$repo = WikibaseRepo::getDefaultInstance();
diff --git a/includes/CrossCheck/Result/CrossCheckResultList.php
b/includes/CrossCheck/Result/CrossCheckResultList.php
index a04834a..1438a8e 100644
--- a/includes/CrossCheck/Result/CrossCheckResultList.php
+++ b/includes/CrossCheck/Result/CrossCheckResultList.php
@@ -48,9 +48,9 @@
/**
* Merges another CrossCheckResultList to the current one
*
- * @param CrossCheckResultList $resultList
+ * @param self $resultList
*/
- public function merge( CrossCheckResultList $resultList ) {
+ public function merge( self $resultList ) {
$this->results = array_merge( $this->results,
$resultList->results );
}
@@ -77,7 +77,7 @@
*
* @param $propertyId
*
- * @return CrossCheckResultList
+ * @return self
*/
public function getByPropertyId( PropertyId $propertyId ) {
$results = array();
diff --git a/includes/ExternalValidationServices.php
b/includes/ExternalValidationServices.php
index 8b047fc..4c6a362 100644
--- a/includes/ExternalValidationServices.php
+++ b/includes/ExternalValidationServices.php
@@ -80,7 +80,7 @@
* Returns the default instance.
* IMPORTANT: Use only when it is not feasible to inject an instance
properly.
*
- * @return ExternalValidationServices
+ * @return self
*/
public static function getDefaultInstance() {
static $instance = null;
diff --git a/specials/SpecialExternalDbs.php b/specials/SpecialExternalDbs.php
index 7d62bbb..5752f0a 100644
--- a/specials/SpecialExternalDbs.php
+++ b/specials/SpecialExternalDbs.php
@@ -8,7 +8,6 @@
use SpecialPage;
use Wikibase\DataModel\Services\Lookup\LanguageLabelDescriptionLookup;
use Wikibase\DataModel\Services\Lookup\TermLookup;
-use Wikibase\Lib\Store\EntityTitleLookup;
use Wikibase\Repo\EntityIdHtmlLinkFormatterFactory;
use Wikibase\Repo\WikibaseRepo;
use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation;
@@ -32,7 +31,8 @@
/**
* Creates new instance from global state.
- * @return SpecialExternalDbs
+ *
+ * @return self
*/
public static function newFromGlobalState() {
$repo = WikibaseRepo::getDefaultInstance();
@@ -47,7 +47,7 @@
/**
* @param TermLookup $termLookup
- * @param EntityTitleLookup $entityTitleLookup
+ * @param EntityIdHtmlLinkFormatterFactory
$entityIdHtmlLinkFormatterFactory
* @param DumpMetaInformationLookup $dumpMetaInformationRepo
*/
public function __construct(
--
To view, visit https://gerrit.wikimedia.org/r/270570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7203cfd7189aa5d6bfe11bb867d313bee248d850
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Soeren.oldag <[email protected]>
Gerrit-Reviewer: Tamslo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
