OliverKeyes has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271760
Change subject: Fix 'none' bug
......................................................................
Fix 'none' bug
Fixes a bug where 'none' was displayed as a possible source of
search engine traffic, along with but not instead of 'Not referred
by search'.
Bug: T127381
Change-Id: Ic6efa10cfa3a961de11018c1c7bde8a324898915
---
M utils.R
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/wonderbolt
refs/changes/60/271760/1
diff --git a/utils.R b/utils.R
index 4cf528a..3a801de 100644
--- a/utils.R
+++ b/utils.R
@@ -15,7 +15,7 @@
# Format
data$is_search <- ifelse(data$is_search, "Referred by search", "Not referred
by search")
- data$search_engine[data$search_engine == "None"] <- "Not referred by search"
+ data$search_engine[data$search_engine %in% c("none","None")] <- "Not
referred by search"
# Write out the overall values for traffic
holding <- data[, j = list(pageviews = sum(pageviews)),
--
To view, visit https://gerrit.wikimedia.org/r/271760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6efa10cfa3a961de11018c1c7bde8a324898915
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/wonderbolt
Gerrit-Branch: master
Gerrit-Owner: OliverKeyes <oke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
