jenkins-bot has submitted this change and it was merged.
Change subject: Use MenuOptionWidget rather than OptionWidget for
MenuSelectWidget items
......................................................................
Use MenuOptionWidget rather than OptionWidget for MenuSelectWidget items
The current way surprisingly mostly works, but you're supposed to use
the matching class. This fixes some styling inconsistencies.
Change-Id: I3f8ce19b1f96cc051b7ac987fa211d1b5ee9cc71
---
M modules/ext.templateDataGenerator.ui.tdDialog.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.templateDataGenerator.ui.tdDialog.js
b/modules/ext.templateDataGenerator.ui.tdDialog.js
index a617e3c..26f08c2 100644
--- a/modules/ext.templateDataGenerator.ui.tdDialog.js
+++ b/modules/ext.templateDataGenerator.ui.tdDialog.js
@@ -386,7 +386,7 @@
if ( $.inArray( newLanguage, this.availableLanguages ) === -1 )
{
// Add new language
this.availableLanguages.push( newLanguage );
- languageButton = new OO.ui.OptionWidget( {
+ languageButton = new OO.ui.MenuOptionWidget( {
data: newLanguage,
label: $.uls.data.getAutonym( newLanguage )
} );
@@ -665,7 +665,7 @@
case 'type':
propInput = new OO.ui.DropdownWidget( config );
for ( type in paramProperties[ props ].children
) {
- typeItemArray.push( new
OO.ui.OptionWidget( {
+ typeItemArray.push( new
OO.ui.MenuOptionWidget( {
data: paramProperties[ props
].children[ type ],
label: mw.msg(
'templatedata-modal-table-param-type-' + paramProperties[ props ].children[
type ] )
} ) );
@@ -850,7 +850,7 @@
$.inArray( language, languages ) === -1
) {
// Add the default language
- languageItems.push( new OO.ui.OptionWidget( {
+ languageItems.push( new OO.ui.MenuOptionWidget(
{
data: language,
label: $.uls.data.getAutonym( language )
} ) );
@@ -859,7 +859,7 @@
// Add all available languages
for ( i = 0; i < languages.length; i++ ) {
- languageItems.push( new OO.ui.OptionWidget( {
+ languageItems.push( new OO.ui.MenuOptionWidget(
{
data: languages[ i ],
label: $.uls.data.getAutonym(
languages[ i ] )
} ) );
--
To view, visit https://gerrit.wikimedia.org/r/269176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f8ce19b1f96cc051b7ac987fa211d1b5ee9cc71
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
