Dvogel hallowelt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272459
Change subject: OnDoEditSectionLink: check if used skin is BlueSpiceSkin before
......................................................................
OnDoEditSectionLink: check if used skin is BlueSpiceSkin before
adding class 'icon-pencil' to avoid rendering icon font to other skins.
Change-Id: Ib43536c8bc17b02b379f3dd271d418bbab41f1a8
---
M includes/BlueSpiceSkinHooks.php
1 file changed, 18 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/BlueSpiceSkin
refs/changes/59/272459/1
diff --git a/includes/BlueSpiceSkinHooks.php b/includes/BlueSpiceSkinHooks.php
index 396b6da..300b8cb 100644
--- a/includes/BlueSpiceSkinHooks.php
+++ b/includes/BlueSpiceSkinHooks.php
@@ -46,22 +46,24 @@
* @return boolean Always true to keep Hook running
*/
public static function onDoEditSectionLink($skin, $title, $section,
$tooltip, &$result, $lang = false) {
- $result = Linker::link(
- $title,
- Html::element(
- 'span',
- array(),
- wfMessage( 'editsection' )->inLanguage( $lang
)->text()
- ),
- array(
- 'class' => 'mw-editsection icon-pencil',
- 'title' => $tooltip
- ),
- array(
- 'action' => 'edit',
- 'section' => $section
- )
- );
+ if ( $skin->getSkinName() == 'bluespiceskin' ) {
+ $result = Linker::link(
+ $title,
+ Html::element(
+ 'span',
+ array(),
+ wfMessage( 'editsection' )->inLanguage(
$lang )->text()
+ ),
+ array(
+ 'class' => 'mw-editsection icon-pencil',
+ 'title' => $tooltip
+ ),
+ array(
+ 'action' => 'edit',
+ 'section' => $section
+ )
+ );
+ }
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/272459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib43536c8bc17b02b379f3dd271d418bbab41f1a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSpiceSkin
Gerrit-Branch: REL1_23
Gerrit-Owner: Dvogel hallowelt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
