Anomie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272464
Change subject: Fix session store logging
......................................................................
Fix session store logging
Two things were wrong here:
1. SessionManager shouldn't override the configured logger of the
underlying store.
2. CachedBagOStuff shouldn't override the configured logger of the
backend store on construction.
Change-Id: I24ed5a81d5b238a42934a7890dd8d0a9f9bb3b6f
---
M includes/libs/objectcache/CachedBagOStuff.php
M includes/session/SessionManager.php
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/64/272464/1
diff --git a/includes/libs/objectcache/CachedBagOStuff.php
b/includes/libs/objectcache/CachedBagOStuff.php
index c71b16e..798357d 100644
--- a/includes/libs/objectcache/CachedBagOStuff.php
+++ b/includes/libs/objectcache/CachedBagOStuff.php
@@ -76,11 +76,6 @@
return true;
}
- public function setLogger( LoggerInterface $logger ) {
- parent::setLogger( $logger );
- $this->backend->setLogger( $logger );
- }
-
public function setDebug( $bool ) {
parent::setDebug( $bool );
$this->backend->setDebug( $bool );
diff --git a/includes/session/SessionManager.php
b/includes/session/SessionManager.php
index 0abec1b..8695b68 100644
--- a/includes/session/SessionManager.php
+++ b/includes/session/SessionManager.php
@@ -168,7 +168,6 @@
$store = $options['store'];
} else {
$store = \ObjectCache::getInstance( $this->config->get(
'SessionCacheType' ) );
- $store->setLogger( $this->logger );
}
$this->store = $store instanceof CachedBagOStuff ? $store : new
CachedBagOStuff( $store );
--
To view, visit https://gerrit.wikimedia.org/r/272464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24ed5a81d5b238a42934a7890dd8d0a9f9bb3b6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
