jenkins-bot has submitted this change and it was merged.
Change subject: Check node is an element before doing classList.contains
......................................................................
Check node is an element before doing classList.contains
Avoids an exception being thrown when element is a text node.
Change-Id: Iff26c78b5431990075a8e9058c3689797f9589cd
(cherry picked from commit bf122f62983d558ad3e8974d16361163b96bebc0)
---
M src/ce/ve.ce.Document.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Document.js b/src/ce/ve.ce.Document.js
index d9f5f27..f2ebefb 100644
--- a/src/ce/ve.ce.Document.js
+++ b/src/ce/ve.ce.Document.js
@@ -193,7 +193,7 @@
if ( slug && (
!slug.firstChild ||
$( slug ).hasClass( 've-ce-branchNode-blockSlug' ) ||
- $( slug.firstChild ).hasClass( 've-ce-chimera' )
+ ( slug.firstChild.nodeType === Node.ELEMENT_NODE &&
slug.firstChild.classList.contains( 've-ce-chimera' ) )
) ) {
return { node: slug, offset: 0 };
}
--
To view, visit https://gerrit.wikimedia.org/r/272507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff26c78b5431990075a8e9058c3689797f9589cd
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.27.0-wmf.14
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
