Aude has submitted this change and it was merged. Change subject: (hotfix) $prefs should be passed by reference ......................................................................
(hotfix) $prefs should be passed by reference - $prefs should be passed by reference in the onGetPreferences hook; not doing so, leads to the new preference not showing up for me (php 5.4); according to the documentation of the hook, passing by reference is the correct way; Change-Id: Ia942f4cd9622b50f86a27e8d5dbc5dc53ae17a2c --- M client/WikibaseClient.hooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/43159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia942f4cd9622b50f86a27e8d5dbc5dc53ae17a2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
