Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/272693
Change subject: Clean up PHPUnit test files ...................................................................... Clean up PHPUnit test files Change-Id: I9484f29dfb07790b6a0c9bdd5544453cb30c555d --- M tests/phpunit/output/BasicRowTest.php M tests/phpunit/output/BasicTest.php 2 files changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Capiunto refs/changes/93/272693/1 diff --git a/tests/phpunit/output/BasicRowTest.php b/tests/phpunit/output/BasicRowTest.php index 6aabf28..ed19044 100644 --- a/tests/phpunit/output/BasicRowTest.php +++ b/tests/phpunit/output/BasicRowTest.php @@ -2,6 +2,9 @@ namespace Capiunto\Test; +use Scribunto_LuaEngine; +use Scribunto_LuaEngineTestBase; + /** * A basic Infobox output test * @@ -9,17 +12,18 @@ * * @author Marius Hoch < [email protected] > */ -class RowInfobox extends \Scribunto_LuaEngineTestBase { +class BasicRowTest extends Scribunto_LuaEngineTestBase { + public function provideLuaData() { - // We need to override this to prevent the parent from doing things we don't want/need return array(); } public function testLua() { - $this->assertTrue( true, "Scribunto expects all tests to go through this…" ); + $this->assertTrue( true ); } public function testOutput() { + /** @var Scribunto_LuaEngine $engine */ $engine = $this->getEngine(); $interpreter = $engine->getInterpreter(); @@ -42,6 +46,6 @@ $box, "Basic row infobox integration test didn't create expected html" ); - } + } diff --git a/tests/phpunit/output/BasicTest.php b/tests/phpunit/output/BasicTest.php index c709dfe..3b83b02 100644 --- a/tests/phpunit/output/BasicTest.php +++ b/tests/phpunit/output/BasicTest.php @@ -2,6 +2,9 @@ namespace Capiunto\Test; +use Scribunto_LuaEngine; +use Scribunto_LuaEngineTestBase; + /** * A basic Infobox output test * @@ -9,17 +12,18 @@ * * @author Marius Hoch < [email protected] > */ -class BasicInfobox extends \Scribunto_LuaEngineTestBase { +class BasicTest extends Scribunto_LuaEngineTestBase { + public function provideLuaData() { - // We need to override this to prevent the parent from doing things we don't want/need return array(); } public function testLua() { - $this->assertTrue( true, "Scribunto expects all tests to go through this…" ); + $this->assertTrue( true ); } public function testOutput() { + /** @var Scribunto_LuaEngine $engine */ $engine = $this->getEngine(); $interpreter = $engine->getInterpreter(); @@ -42,6 +46,6 @@ $box, "Basic infobox integration test didn't create expected html" ); - } + } -- To view, visit https://gerrit.wikimedia.org/r/272693 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9484f29dfb07790b6a0c9bdd5544453cb30c555d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Capiunto Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
