Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272760
Change subject: Add GENDER support to 'View changes'
......................................................................
Add GENDER support to 'View changes'
Change-Id: I42b8b253b8b865c081ba1aec62848afadd21e0f4
---
M i18n/en.json
M i18n/qqq.json
M includes/formatters/EditUserTalkPresentationModel.php
M includes/formatters/MentionPresentationModel.php
M includes/formatters/RevertedPresentationModel.php
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/60/272760/1
diff --git a/i18n/en.json b/i18n/en.json
index f086b11..c2f9074 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -65,7 +65,7 @@
"notification-link-text-collapse-all": "Collapse all",
"notification-link-text-view-message": "View message",
"notification-link-text-view-mention": "View mention",
- "notification-link-text-view-changes": "View changes",
+ "notification-link-text-view-changes": "{{GENDER:$1|View}} changes",
"notification-link-text-view-page": "View page",
"notification-link-text-view-edit": "View edit",
"notification-edit-talk-page2": "[[User:$1|$1]] {{GENDER:$1|left}} a
message on your [[User talk:$2#$3|talk page]].",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 3667e32..2685150 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -86,7 +86,7 @@
"notification-link-text-collapse-all": "Label for the button that
collapses a bundled notification.\n{{Identical|Collapse}}",
"notification-link-text-view-message": "Label for button that links to
a message on your talk page.\n{{Identical|View message}}",
"notification-link-text-view-mention": "Label for button that links to
a discussion where you were mentioned.",
- "notification-link-text-view-changes": "Label for button that links to
a \"diff\" view showing changes made to a page. This is an alternative to the
wording in {{msg-mw|notification-link-text-view-edit}}, which serves
essentially the same function.\n{{Identical|View changes}}",
+ "notification-link-text-view-changes": "Label for button that links to
a \"diff\" view showing changes made to a page. This is an alternative to the
wording in {{msg-mw|notification-link-text-view-edit}}, which serves
essentially the same function. Paramters:\n* $1 - name of the user viewing the
notification, can be used for GENDER.\n{{Identical|View changes}}",
"notification-link-text-view-page": "Label for button that links to a
page.\n{{Identical|View page}}",
"notification-link-text-view-edit": "Label for button that links to a
\"diff\" view showing an edit made to a page. This is an alternative to the
wording in {{msg-mw|notification-link-text-view-changes}}, which serves
essentially the same function.",
"notification-edit-talk-page2": "Format for displaying notifications of
a user talk page being edited. Parameters:\n* $1 - the username of the person
who edited, plain text. Can be used for GENDER.\n* $2 - the current user's
name, used in the link to their talk page\n* $3 - the section title of the
discussion, if any, used in the link to their talk page\nSee also:\n*
{{msg-mw|Notification-edit-talk-page-flyout2}}\n*
{{msg-mw|Notification-add-talkpage-topic2}}\n* left is for verb left.",
diff --git a/includes/formatters/EditUserTalkPresentationModel.php
b/includes/formatters/EditUserTalkPresentationModel.php
index 9847909..1af5ea1 100644
--- a/includes/formatters/EditUserTalkPresentationModel.php
+++ b/includes/formatters/EditUserTalkPresentationModel.php
@@ -29,7 +29,7 @@
public function getSecondaryLinks() {
$diffLink = array(
'url' => $this->getDiffLinkUrl(),
- 'label' => $this->msg(
'notification-link-text-view-changes' )->text(),
+ 'label' => $this->msg(
'notification-link-text-view-changes', $this->getViewingUserForGender()
)->text(),
'description' => '',
'icon' => 'changes',
'prioritized' => true
diff --git a/includes/formatters/MentionPresentationModel.php
b/includes/formatters/MentionPresentationModel.php
index e215e08..66f8c4c 100644
--- a/includes/formatters/MentionPresentationModel.php
+++ b/includes/formatters/MentionPresentationModel.php
@@ -135,7 +135,7 @@
) );
$viewChangesLink = array(
'url' => $url,
- 'label' => $this->msg(
'notification-link-text-view-changes' )->text(),
+ 'label' => $this->msg(
'notification-link-text-view-changes', $this->getViewingUserForGender()
)->text(),
'description' => '',
'icon' => 'changes',
'prioritized' => true,
diff --git a/includes/formatters/RevertedPresentationModel.php
b/includes/formatters/RevertedPresentationModel.php
index 4261d6f..3b7d85f 100644
--- a/includes/formatters/RevertedPresentationModel.php
+++ b/includes/formatters/RevertedPresentationModel.php
@@ -43,7 +43,7 @@
) );
return array(
'url' => $url,
- 'label' => $this->msg(
'notification-link-text-view-changes' )->text()
+ 'label' => $this->msg(
'notification-link-text-view-changes', $this->getViewingUserForGender()
)->text()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/272760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42b8b253b8b865c081ba1aec62848afadd21e0f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
