Anomie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272893
Change subject: User::isSafeToLoad() should return false if MW_NO_SESSION
......................................................................
User::isSafeToLoad() should return false if MW_NO_SESSION
Because it's never safe.
Bug: T127772
Change-Id: Ieb5824f1668dc38d1be7c7cbf799da17e581c555
---
M includes/user/User.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/272893/1
diff --git a/includes/user/User.php b/includes/user/User.php
index eb3853a..34ef181 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -327,7 +327,8 @@
*/
public function isSafeToLoad() {
global $wgFullyInitialised;
- return $wgFullyInitialised || $this->mLoadedItems === true ||
$this->mFrom !== 'session';
+ return ( !defined( 'MW_NO_SESSION' ) && $wgFullyInitialised ) ||
+ $this->mLoadedItems === true || $this->mFrom !==
'session';
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/272893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb5824f1668dc38d1be7c7cbf799da17e581c555
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
