jenkins-bot has submitted this change and it was merged.
Change subject: Make surface measurable while activating
......................................................................
Make surface measurable while activating
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.
Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
index cd88cef..b27162b 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
@@ -32,11 +32,18 @@
.ve-activated #t-permalink,
.ve-activated #p-coll-print_export,
.ve-activated #t-cite,
-.ve-activating .ve-ui-surface,
.ve-deactivating .ve-ui-surface {
display: none;
}
+/* The surface needs to be measurable while being setup
+ as some nodes render based on their dimensions, e.g.
+ ve.ce.FocusableNode#updateInvisibleIcon */
+.ve-activating .ve-ui-surface {
+ height: 0;
+ overflow: hidden;
+}
+
.ve-activated #bodyContent,
.ve-activated #firstHeading {
opacity: 0.6;
--
To view, visit https://gerrit.wikimedia.org/r/272763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
