Sbisson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/272998

Change subject: Handle null user when trying to generate a link for 
notifications
......................................................................

Handle null user when trying to generate a link for notifications

Bug: T127728
Change-Id: I87de2d10887216e3edf53c2972b6bf230191f0ea
---
M includes/formatters/EventPresentationModel.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/98/272998/1

diff --git a/includes/formatters/EventPresentationModel.php 
b/includes/formatters/EventPresentationModel.php
index 05d5211..a114c47 100644
--- a/includes/formatters/EventPresentationModel.php
+++ b/includes/formatters/EventPresentationModel.php
@@ -381,10 +381,14 @@
        }
 
        /**
-        * @param User $user
+        * @param User|null $user
         * @return array|null
         */
-       final protected function getUserLink( User $user ) {
+       final protected function getUserLink( $user ) {
+               if ( !$user ) {
+                       return null;
+               }
+
                if ( !$this->userCan( Revision::DELETED_USER ) ) {
                        return null;
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/272998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87de2d10887216e3edf53c2972b6bf230191f0ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to